Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update everything to alpine 3.13 and go 1.15 #723

Merged
merged 4 commits into from
Jan 21, 2021
Merged

Conversation

vladaionescu
Copy link
Member

@vladaionescu vladaionescu commented Jan 21, 2021

  • s/alpine:3.11/alpine:3.13
  • s/alpine3.11/alpine3.13
  • s/golang:1.13-alpine3.13/golang:1.15-alpine3.13

@vladaionescu vladaionescu changed the title Update everything to alpine 3.13 Update everything to alpine 3.13 and go 1.15 Jan 21, 2021
Copy link

@kevinkjt2000 kevinkjt2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing all the places where 3.11 was changed to 3.13, makes me crave for +vars/ALPINE_VERSION

+base | resolve docker.io/library/golang:1.13-alpine3.11@sha256:7d45a6fc9cde63c3bf41651736996fe94a8347e726fe581926fd8c26e244e3b2 0%
+base | resolve docker.io/library/golang:1.13-alpine3.11@sha256:7d45a6fc9cde63c3bf41651736996fe94a8347e726fe581926fd8c26e244e3b2 100%
+base | --> FROM golang:1.15-alpine3.13
+base | resolve docker.io/library/golang:1.15-alpine3.13@sha256:7d45a6fc9cde63c3bf41651736996fe94a8347e726fe581926fd8c26e244e3b2 0%

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this is documentation, but it looks like the checksum should be 07ec52ea1063aa6ca02034af5805aaae77d3d4144cced4e95f09d62a6d8ddf0a

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - yeah this should be fine. It still illustrates the point.

@vladaionescu vladaionescu merged commit 5aa840b into main Jan 21, 2021
@vladaionescu vladaionescu deleted the vlad/alpine-update branch January 21, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants