-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coerce some integer data types #108
Conversation
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
==========================================
+ Coverage 84.07% 84.19% +0.11%
==========================================
Files 32 32
Lines 804 810 +6
Branches 85 87 +2
==========================================
+ Hits 676 682 +6
Misses 103 103
Partials 25 25
Continue to review full report at Codecov.
|
dc8aaf8
to
6e6a4f0
Compare
Dear Andreas, I would rather integrate the integer types in the main function of type coercion. Also with the new column names class-enumeration-mixture arriving through #113 we should fix all those columns at once. I also put comments behind those columns which I believe are integers or strings. All the best, |
Dear Benjamin, thanks for your excellent work on #113. I will rebase my branch on top of your improvements as soon as they have been merged and will follow your suggestions by integrating the integer type casting into the With kind regards, |
Dear Andreas, as we have already spoken about it, please also include those string data types in the type casting. Those rarely seen columns may hold information about the measuring type of e.g. cloud coverage. |
This is just a first shot at #107, further elaboration might touch or resolve aspects from #109.