Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Run software tests on GHA/macOS/M1 #1191

Merged
merged 3 commits into from
Feb 25, 2024
Merged

CI: Run software tests on GHA/macOS/M1 #1191

merged 3 commits into from
Feb 25, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Jan 31, 2024

About

January 30, 2024

GitHub announced the launch of the new M1 macOS runner. It provides 3 vCPU, 7 GB RAM, and 14 GB of storage VM, and the latest Mac hardware Actions has to offer. The new runner operates exclusively on macOS 14 and to use it, simply update the runs-on key in your YAML workflow file to macos-14.

References

@amotl
Copy link
Member Author

amotl commented Jan 31, 2024

Problem

line 1: pipx: command not found

Solution

Needs another patch to make it bootstrap. Thanks, @henryiii.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.86%. Comparing base (6d06232) to head (9591b1e).
Report is 49 commits behind head on main.

❗ Current head 9591b1e differs from pull request most recent head b3d9f5f. Consider uploading reports for the commit b3d9f5f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1191      +/-   ##
==========================================
+ Coverage   90.85%   90.86%   +0.01%     
==========================================
  Files         103      103              
  Lines        9856     9856              
  Branches     1133     1133              
==========================================
+ Hits         8955     8956       +1     
+ Misses        703      702       -1     
  Partials      198      198              
Flag Coverage Δ
unittests 90.86% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neumann-nico
Copy link
Member

neumann-nico commented Feb 25, 2024

Problem

line 1: pipx: command not found

Solution

Needs another patch to make it bootstrap. Thanks, @henryiii.

Couldn't we install pipx as a workaround?
https://github.com/pypa/pipx?tab=readme-ov-file#on-macos

- name: Install pipx
  if: ${{ matrix.os == 'macos-14' }}
  run: |
    brew install pipx
    pipx ensurepath

@henryiii
Copy link

You can, not good for a general composite action (since it affects the environment), but fine for workflows.

@neumann-nico
Copy link
Member

You can, not good for a general composite action (since it affects the environment), but fine for workflows.

Yes exactly. That should be fine for this particular workflow but not great as a general approach.

@gutzbenj
Copy link
Member

@neumann-nico please go ahead and push the suggested change!

@neumann-nico neumann-nico marked this pull request as ready for review February 25, 2024 17:50
@neumann-nico neumann-nico self-requested a review February 25, 2024 17:51
@neumann-nico neumann-nico force-pushed the collab/ci-silicon-m1 branch 4 times, most recently from c6e30f6 to 377b999 Compare February 25, 2024 18:25
@gutzbenj gutzbenj merged commit 6f2634b into main Feb 25, 2024
9 of 17 checks passed
@gutzbenj gutzbenj deleted the collab/ci-silicon-m1 branch February 25, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants