Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable to parse string and not only enumeration to functions. #49

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Enable to parse string and not only enumeration to functions. #49

merged 1 commit into from
Jun 11, 2020

Conversation

meteoDaniel
Copy link
Contributor

Dear @gutzbenj I implemented what I have mentioned in chat. You can now parse a string according to the enum.

And I added a small feature to the get_nearest_station function

@gutzbenj gutzbenj self-requested a review June 8, 2020 20:27
gutzbenj
gutzbenj approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@gutzbenj gutzbenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Daniel,
thank you for the PR. It opens up another way for setting the parameters of the requested data. Nice job and no complaints from my side.

This was referenced Jun 9, 2020
Closed
Closed
@gutzbenj gutzbenj merged commit aea8b2c into master Jun 11, 2020
@amotl amotl mentioned this pull request Jun 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gutzbenj gutzbenj gutzbenj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@meteoDaniel @gutzbenj