Fix data acquisition for solar data from hourly and daily resolutions #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DWD directory structure has an anomaly here: There are no "recent" or "historical" folders for "solar" data within the "hourly" and "daily" time resolutions.
gutzbenj
approved these changes
Jun 16, 2020
gutzbenj
approved these changes
Jun 16, 2020
|
Works for me. Little reminder to work on: #68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again,
Introduction
This is another thing we learned from maintaining
dwdweather2I would like to share in form of code with you.Anomaly
The DWD directory structure has an anomaly: For solar data, there are no "recent" or "historical" folders within the "hourly" and "daily" time resolutions, see [1,2]. Sad but true.
Outlook
When applying this minor fix accounting for the deviation outlined above, this command starts working flawlessly:
As soon as #63 gets merged, it should probably also start working for hourly data.
With kind regards,
Andreas.
[1] https://opendata.dwd.de/climate_environment/CDC/observations_germany/climate/hourly/solar/
[2] https://opendata.dwd.de/climate_environment/CDC/observations_germany/climate/daily/solar/