Make nodes.template.Template a bit more dict-like #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to dict.get, Template.get with a default param supplied will return that value instead of raising an exception. If default is unset, Template.get will keep its previous behavior and raise an exception.
These are just aliases for existing methods, without the ability to specifiy additional parameters. However, including them makes Template more dict-like, so it's a good idea to have them.
Per PEP8, there is no benefit to using a lambda here, and some downsides. It's the same number of SLOC either way, so might as well change it.
This allows the use of `key in Template` syntax
This reverts commit b87f4ee.
|
Sorry I took a while to get to this—looks good. The CI failure can be ignored; I'll remove Python 3.4 from the supported versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__getitem__,__setitem__, and__delitem__methods to Template, allowing the use ofTemplate[param]syntax.Adds a__contains__method to Template, allowing the use ofkey in TemplatesyntaxTemplate.get should really raise a KeyError, not a ValueError, but implementing that would be a breaking change.