Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.5.0 - find summary .txt file id #28

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

growland2
Copy link
Contributor

@growland2 growland2 commented Jun 27, 2024

  • Added code to find summary text file by querying the output of eggd_athena stage of SNV reports workflow
  • Example job which completes successfully run with a now removed print statement to show contents of the SNV data dictionary. See in logs (or screenshot below) for the presence of summary text file ID within the data dict.

image


This change is Reviewable

@growland2 growland2 requested a review from rklocke June 27, 2024 14:40
@pep8speaks
Copy link

pep8speaks commented Jun 27, 2024

Hello @growland2! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 103:80: E501 line too long (118 > 79 characters)

Comment last updated at 2024-06-28 15:06:24 UTC

Copy link
Contributor

@jethror1 jethror1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @rklocke)

@jethror1 jethror1 merged commit d2a859f into DI-915_v1.5.0 Jun 28, 2024
1 check passed
@jethror1 jethror1 deleted the DI-915_v1.5.0_get_summary_text_file_id branch June 28, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants