Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future-proofing, confluence documentation and unit test improvements #5

Closed
wants to merge 25 commits into from

Conversation

PolarisAstrum-NHS
Copy link
Collaborator

@PolarisAstrum-NHS PolarisAstrum-NHS commented May 13, 2024

Added features requested for future-proofing, additional checks in testing, and documenting testing evidence automatically on Confluence.
Restructured code to improve readability.
Increased unit test coverage, improved existing unit tests and added unit tests for new features implemented.


This change is Reviewable

…ence project vep configs during annotation resource update
…ation resource updates and vep config updates
@pep8speaks
Copy link

Hello @PolarisAstrum-NHS! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 22:80: E501 line too long (85 > 79 characters)
Line 28:80: E501 line too long (157 > 79 characters)
Line 29:80: E501 line too long (179 > 79 characters)
Line 30:80: E501 line too long (219 > 79 characters)
Line 31:80: E501 line too long (196 > 79 characters)
Line 41:1: E122 continuation line missing indentation or outdented
Line 139:80: E501 line too long (82 > 79 characters)
Line 152:80: E501 line too long (112 > 79 characters)
Line 333:80: E501 line too long (82 > 79 characters)
Line 335:80: E501 line too long (84 > 79 characters)

Line 9:1: E402 module level import not at top of file
Line 10:1: E402 module level import not at top of file

Line 32:80: E501 line too long (85 > 79 characters)

Line 280:80: E501 line too long (85 > 79 characters)
Line 303:80: E501 line too long (80 > 79 characters)
Line 327:80: E501 line too long (88 > 79 characters)
Line 379:80: E501 line too long (117 > 79 characters)
Line 476:80: E501 line too long (80 > 79 characters)
Line 515:80: E501 line too long (80 > 79 characters)
Line 553:80: E501 line too long (80 > 79 characters)

Line 337:80: E501 line too long (81 > 79 characters)
Line 338:80: E501 line too long (81 > 79 characters)
Line 339:80: E501 line too long (80 > 79 characters)
Line 384:80: E501 line too long (80 > 79 characters)
Line 392:80: E501 line too long (128 > 79 characters)
Line 393:80: E501 line too long (128 > 79 characters)
Line 394:80: E501 line too long (127 > 79 characters)

Line 9:1: E402 module level import not at top of file
Line 95:35: W291 trailing whitespace
Line 99:80: E501 line too long (83 > 79 characters)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants