[Configuration] Fix parallel config always replaced by next config as default to true #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Reinis here to fix #180
The existing
ECSConfigBuilder::$parallel
property is default totrue
, so the$ecsConfig->parallel()
is always called, instead, it needs to be nullable bool:with default to
null
, and callparallel()
ordisableParallel()
when it enabled/disabled:To ensure it enabled by default on the project, I set entry point in
config/config.php
:I tried in this repo and it seems working ok 👍