Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic sets should be configured after sets #188

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

zghosts
Copy link
Contributor

@zghosts zghosts commented Mar 21, 2024

I ran into the same issue as stated in #186
When trying to override a rule in a dynamic set using ruleWithConfiguration, when using the ECSConfigBuilder, the new configuration is not honored, and the configuration from the dynamic set is used.

Like sets, dynamicSets should be defined before anything else, thus allowing for rules and rulesWithConfiguration to override the defaults in the predefined sets.

@TomasVotruba
Copy link
Contributor

Makes sense, thank you for the fix 🙏

@TomasVotruba TomasVotruba merged commit 5002568 into easy-coding-standard:main Mar 21, 2024
7 checks passed
@zghosts
Copy link
Contributor Author

zghosts commented Mar 21, 2024

You're welcome, thanks for all yout work on ECS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants