Dynamic sets should be configured after sets #188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the same issue as stated in #186
When trying to override a rule in a dynamic set using
ruleWithConfiguration
, when using the ECSConfigBuilder, the new configuration is not honored, and the configuration from the dynamic set is used.Like sets, dynamicSets should be defined before anything else, thus allowing for rules and rulesWithConfiguration to override the defaults in the predefined sets.