New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EASYOPAC-1158 - Temporary Bibliofil commit. #627

Closed

mihaelad wants to merge 22 commits into development from EASYOPAC-1158-ms

mihaelad commented Jan 24, 2020

Link to issue

https://inlead.atlassian.net/browse/EASYOPAC-1158

Description

Adaptation for bibliofil theme

Screenshot of the result

Checklist

My complies with our coding guidelines.
My code passes our static analysis suite. If not then I have added a comment explaining why this change should be exempt from the code standards and process.
My code passes our continuous integration process. If not then I have added a comment explaining why this change should be exempt from the code standards and process.

Additional comments or questions

Martin Cording and others added 9 commits

November 25, 2019 14:25


          Merge branch 'development' into release-easyopac

929a3de


          Release: 7.x-5.0.1+easy

d773101


          Hotfix: Double quote typo.

b885aa4


          Merge branch 'hotfix'

b7870bb


          Hotfix: Change text format for campaign description.

3fd133e


          Hotfix: Bump easyddb_ee_import module.

61d1f5d


          Hotfix: Temporary fix for serendipity module.

dbbf3eb


          Hotfix: Reformat JSON array for carousels.

930edbc


          Merge branch 'hotfix'

d3ed7be

guddo changed the title ~~Easyopac 1158 ms~~ EASYOPAC-1158 - Temporary Bibliofil commit.

guddo suggested changes

View reviewed changes

themes/ddbasic/sass/bibliofil/_overides.scss Outdated


		//@import '../base.scss';

		//Overid the background for body

guddo Jan 24, 2020

Start with a space, end with a dot. Override is spelled with "e" in the end.

themes/ddbasic/sass/bibliofil/_overides.scss Outdated

+                color: $white;
+              }
+              //Overid the background for content and messages

guddo Jan 24, 2020

Start with a space, end with a dot. Override is spelled with "e" in the end.

themes/ddbasic/sass/bibliofil/_overides.scss Outdated

+                .pane-content {
+                  .frontpage-layout {
+                    .panel-pane{
+                  background-color: $bibliofil;

guddo Jan 24, 2020

Indent is wrong.

themes/ddbasic/sass/bibliofil/_overides.scss Outdated

+                }
+              }
+               div.panels-ipe-placeholder {
+                  background-color: $bibliofil-dark;

guddo Jan 24, 2020

Indent should be 2 spaces.

themes/ddbasic/sass/bibliofil/_overides.scss Outdated

+                }
+              }
+              //Overid the background and color for input

guddo Jan 24, 2020

Start with a space, end with a dot. Override is spelled with "e" in the end.

themes/ddbasic/sass/bibliofil/_overides.scss Outdated

+                  }
+                }
+              }
+              // Main menu third level

guddo Jan 24, 2020

End with a dot, start with a blank line.

themes/ddbasic/sass/bibliofil/_overides.scss Outdated

+                  }
+                }
+              }
+              //event

guddo Jan 24, 2020

Start with a space, end with a dot.

themes/ddbasic/sass/bibliofil/_overides.scss Outdated

+                }
+              }
+              //news

guddo Jan 24, 2020

Start with a space, end with a dot.

themes/ddbasic/sass/bibliofil/_overides.scss Outdated

+                .views-widget-filter-og_group_ref_target_id_entityreference_filter {
+                  label {
+                    h2 {
+                       border-top: 1px solid $white-opacity-light;

guddo Jan 24, 2020

Wrong indent.

themes/ddbasic/sass/bibliofil/_variables.scss Outdated

+              $bibliofil-dark: #2c2c30;
+              $bibliofil-button: #5b9f50;
+              $black: #000;

guddo Jan 24, 2020

You set all variables again? Why not just set the ones needed?

guddo added DO NOT MERGE work in progress labels

GitCop commented Jan 28, 2020

There were the following issues with your Pull Request

Commit: 6ef7a95
Commits must be in the following format: [issue ID] - [short summary of change]

Guidelines are available at https://github.com/easySuite/ding2

This message was auto-generated by https://gitcop.com

GitCop commented Jan 28, 2020

There were the following issues with your Pull Request

Commit: 6ef7a95
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: fc14e85
Commits must be in the following format: [issue ID] - [short summary of change]

Guidelines are available at https://github.com/easySuite/ding2

This message was auto-generated by https://gitcop.com

7 similar comments

GitCop commented Jan 29, 2020

There were the following issues with your Pull Request

Commit: 6ef7a95
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: fc14e85
Commits must be in the following format: [issue ID] - [short summary of change]

Guidelines are available at https://github.com/easySuite/ding2

This message was auto-generated by https://gitcop.com

GitCop commented Jan 30, 2020

There were the following issues with your Pull Request

Commit: 6ef7a95
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: fc14e85
Commits must be in the following format: [issue ID] - [short summary of change]

Guidelines are available at https://github.com/easySuite/ding2

This message was auto-generated by https://gitcop.com

GitCop commented Jan 30, 2020

There were the following issues with your Pull Request

Commit: 6ef7a95
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: fc14e85
Commits must be in the following format: [issue ID] - [short summary of change]

Guidelines are available at https://github.com/easySuite/ding2

This message was auto-generated by https://gitcop.com

GitCop commented Jan 30, 2020

There were the following issues with your Pull Request

Commit: 6ef7a95
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: fc14e85
Commits must be in the following format: [issue ID] - [short summary of change]

Guidelines are available at https://github.com/easySuite/ding2

This message was auto-generated by https://gitcop.com

GitCop commented Jan 30, 2020

There were the following issues with your Pull Request

Commit: 6ef7a95
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: fc14e85
Commits must be in the following format: [issue ID] - [short summary of change]

Guidelines are available at https://github.com/easySuite/ding2

This message was auto-generated by https://gitcop.com

GitCop commented Jan 30, 2020

There were the following issues with your Pull Request

Commit: 6ef7a95
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: fc14e85
Commits must be in the following format: [issue ID] - [short summary of change]

Guidelines are available at https://github.com/easySuite/ding2

This message was auto-generated by https://gitcop.com

GitCop commented Jan 31, 2020

There were the following issues with your Pull Request

Commit: 6ef7a95
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: fc14e85
Commits must be in the following format: [issue ID] - [short summary of change]

Guidelines are available at https://github.com/easySuite/ding2

This message was auto-generated by https://gitcop.com

guddo force-pushed the EASYOPAC-1158-ms branch from e592e00 to 146e7a2 Compare

January 31, 2020 12:36

GitCop commented Jan 31, 2020

There were the following issues with your Pull Request

Commit: 6ef7a95
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: fc14e85
Commits must be in the following format: [issue ID] - [short summary of change]

Guidelines are available at https://github.com/easySuite/ding2

This message was auto-generated by https://gitcop.com

guddo force-pushed the EASYOPAC-1158-ms branch from 146e7a2 to e49bc0f Compare

January 31, 2020 12:37

GitCop commented Jan 31, 2020

There were the following issues with your Pull Request

Commit: d81fc2f
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: e96a23d
Commits must be in the following format: [issue ID] - [short summary of change]

Guidelines are available at https://github.com/easySuite/ding2

This message was auto-generated by https://gitcop.com

guddo force-pushed the EASYOPAC-1158-ms branch from e49bc0f to 595c63c Compare

January 31, 2020 12:38

GitCop commented Jan 31, 2020

There were the following issues with your Pull Request

Commit: 5930ce1
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: 1b37dd8
Commits must be in the following format: [issue ID] - [short summary of change]

Guidelines are available at https://github.com/easySuite/ding2

This message was auto-generated by https://gitcop.com

guddo force-pushed the EASYOPAC-1158-ms branch 2 times, most recently from 35b1f9f to 444faeb Compare

January 31, 2020 12:41

guddo force-pushed the EASYOPAC-1158-ms branch 2 times, most recently from 64852f1 to 0345e92 Compare

January 31, 2020 15:17

GitCop commented Feb 2, 2020

There were the following issues with your Pull Request

Commit: 6ef7a95
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: fc14e85
Commits must be in the following format: [issue ID] - [short summary of change]

Guidelines are available at https://github.com/easySuite/ding2

This message was auto-generated by https://gitcop.com

guddo force-pushed the EASYOPAC-1158-ms branch 2 times, most recently from 0345e92 to fb8559b Compare

February 3, 2020 15:35

Martin Cording added 2 commits

February 18, 2020 09:58


          Merge branch 'development' into release-easyopac


          Release: 7.x-5.0.2+easy

582ae7b

GitCop commented Feb 27, 2020

There were the following issues with your Pull Request

Commit: 15efcad
Your subject line is longer than 72 characters

Guidelines are available at https://github.com/easySuite/ding2

This message was auto-generated by https://gitcop.com

4 similar comments

GitCop commented Mar 2, 2020

There were the following issues with your Pull Request

Commit: 15efcad
Your subject line is longer than 72 characters

Guidelines are available at https://github.com/easySuite/ding2

This message was auto-generated by https://gitcop.com

GitCop commented Mar 9, 2020

There were the following issues with your Pull Request

Commit: 15efcad
Your subject line is longer than 72 characters

Guidelines are available at https://github.com/easySuite/ding2

This message was auto-generated by https://gitcop.com

GitCop commented Mar 9, 2020

There were the following issues with your Pull Request

Commit: 15efcad
Your subject line is longer than 72 characters

Guidelines are available at https://github.com/easySuite/ding2

This message was auto-generated by https://gitcop.com

GitCop commented Mar 18, 2020

There were the following issues with your Pull Request

Commit: 15efcad
Your subject line is longer than 72 characters

Guidelines are available at https://github.com/easySuite/ding2

This message was auto-generated by https://gitcop.com

Martin Cording and others added 10 commits

April 15, 2020 11:48


          Merge branch 'development' into release-easyopac

d9e57e6


          Release: 7.x-6.0.1+easy

6f1fb05


          EASYOPAC-1158 - Added style for bibliofil theme.

a73372e


          EASYOPAC-1158 - Added modules to make file and cleaned up theme.

676ef75


          EASYOPAC-1158 - Added fix for library page.

1d3ed9d


          EASYOPAC-1158 - Changed color for dw calendar and changed font for so…

4abc34b

…cial media.


          EASYOPAC-1158 - Added bg for user and tags pages.

849ac4f


          EASYOPAC-1158 - Use similar styles as Bibliofil.

194e144


          EASYOPAC-1158 - Do not rely on opensearch.

a9e3c61


          EASYOPAC-1158 - Added style for OH.

df38c25

guddo force-pushed the EASYOPAC-1158-ms branch from e1e2381 to df38c25 Compare

April 17, 2020 09:08

GitCop commented Apr 17, 2020

There were the following issues with your Pull Request

Commit: b885aa4
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: 3fd133e
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: 61d1f5d
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: dbbf3eb
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: 930edbc
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: 4abc34b
Your subject line is longer than 72 characters

Guidelines are available at https://github.com/easySuite/ding2

This message was auto-generated by https://gitcop.com


          Bibliofil: Prevent errors.

0114b79

GitCop commented Apr 20, 2020

There were the following issues with your Pull Request

Commit: b885aa4
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: 3fd133e
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: 61d1f5d
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: dbbf3eb
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: 930edbc
Commits must be in the following format: [issue ID] - [short summary of change]
Commit: 4abc34b
Your subject line is longer than 72 characters
Commit: 0114b79
Commits must be in the following format: [issue ID] - [short summary of change]

Guidelines are available at https://github.com/easySuite/ding2

This message was auto-generated by https://gitcop.com

guddo closed this

guddo deleted the EASYOPAC-1158-ms branch

May 5, 2020 14:06

guddo restored the EASYOPAC-1158-ms branch

May 13, 2020 08:30

guddo deleted the EASYOPAC-1158-ms branch

May 13, 2020 08:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE work in progress