-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Broken templating in EasyBuild 4.7.0 #2881
Comments
According to this, it worked at least up to version 4.6.0:
Looking at one of these recipes, built with EasyBuild 4.6.0:
|
This commit from @Flamefire is my first suspect. It messes with |
If I've got my testing correct:
|
That would match the above commit, I think |
I confirmed that this can not be reproduced using This mean is indeed a likely culprit, so I'll move this issue into the easyblocks repo... |
There's another recently opened issue (easybuilders/easybuild-easyconfigs#17259) caused by this PR #2514 |
To avoid running into this in the future, it may be worth displaying a warning when |
We need to get the original value not resolving templates to keep them e.g. for further iterations. Fixes easybuilders#2881
Actually the issue is I haven't found any of our ECs to be affected by this. If anyone can share one to test this that would help. |
We need to get the original value not resolving templates to keep them e.g. for further iterations. Fixes easybuilders#2881
That PR may have another regression related to iterating options: First time the Example (after fix) of a single run with 2 python versions:
|
I disagree the issue is It is reasonable to call
You will find many in our fork https://github.com/ComputeCanada/easybuild-easyconfigs |
At least, I would add a test like the one proposed in so that the build fails hard and clearly, rather than failing silently and letting the user to ponder |
Partial revert of easybuilders#2541: Do not modify `cfg['configopts']` but simply read them and pass the combined result to `run_cmd`. This fixes an issue with templating while iterating over e.g. multiple Pythons and also avoids keeping values in configopts over multiple iterations/builds. Fixes easybuilders#2881
That is actually a different issue. I fixed that with a patch in easybuilders/easybuild-easyconfigs#17288
Not sure how we can reasonably do that as we do |
I am not sure exactly when it happened, but recent EasyBuild versions broke template replacement in
configopts
when usingmulti_deps
, i.e. :for a
CMakeMake
EasyBlock (maybe others, I have not tested) no longer yield builds with differentconfigopts
argument based on%(pyshortver)s
.In a previous build log,
%(pyshortver)s
gets replaced for every iteration:while in a recent build, it keeps the same value as for the first iteration:
The text was updated successfully, but these errors were encountered: