add warning whenever a value with a template is replaced by a value without template

[mboisson]

… replaced by a value without template

[lexming]

I looked at the related issue and I wonder if we can define a more clear behaviour here. Ideally I would trigger a straight error when the template replacement is dangerous/unintended and not do anything otherwise.

Maybe we can check if templating is disabled through EasyConfig.enable_templating and in such a case trigger an error whenever __setitem__ replaces a template. If templating is enabled probably is not an issue. What do you think? Would this approach work?

[mboisson]

I looked at the related issue and I wonder if we can define a more clear behaviour here. Ideally I would trigger a straight error when the template replacement is dangerous/unintended and not do anything otherwise.

Maybe we can check if templating is disabled through EasyConfig.enable_templating and in such a case trigger an error whenever __setitem__ replaces a template. If templating is enabled probably is not an issue. What do you think? Would this approach work?

Raising an error makes existing tests fail. That's why I switched to a warning. See https://github.com/easybuilders/easybuild-framework/pull/4212/checks?check_run_id=11226883289

[boegel]

There's various reasons why passing a "raw" string value (with unresolved template values) makes sense, and some template values (like %(pyver)s) can only be resolved until some installation step has been reached (like prepare step, where dependencies are loaded), so a warning like this would result in quite a lot of false positives, rendering it useless...

[mboisson]

There's various reasons why passing a "raw" string value (with unresolved template values) makes sense, and some template values (like %(pyver)s) can only be resolved until some installation step has been reached (like prepare step, where dependencies are loaded), so a warning like this would result in quite a lot of false positives, rendering it useless...

Hum ? That warning is precisely the opposite, i.e. when a "non-raw" string value (with resolved template values) is used to overwrite a raw one.