New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
armadillo changed their library directory in recent versions from lib… #1213
Conversation
@boegel Mmmm, the failed test seems unrelated to this PR |
failing tests fixed by easybuilders/easybuild-framework#2258, I'll retrigger them |
easybuild/easyblocks/a/armadillo.py
Outdated
custom_paths = { | ||
'files': ['include/armadillo', 'lib/libarmadillo.%s' % get_shared_lib_ext()], | ||
'files': ['include/armadillo', libdir + '/libarmadillo.%s' % get_shared_lib_ext()], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more Python-esque:
os.path.join(libdir, 'libarmadillo.%s' % get_shared_lib_ext())
@mboisson Do you have a PR for an easyconfig for a recent version of Armadillo that requires this? |
nvm, found it: easybuilders/easybuild-easyconfigs#4849 |
Done |
Tested with existing Armadillo easyconfigs & easybuilders/easybuild-easyconfigs#4849, good to go, thanks @mboisson! |
… to lib64
This patch fixes that.