Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default target GitHub account/organisation for --new-pr & co + fix tests that got broken by migration to github.com/easybuilders #2258

Merged
merged 4 commits into from Jul 5, 2017

Conversation

boegel
Copy link
Member

@boegel boegel commented Jul 5, 2017

fix for #2257

@boegel
Copy link
Member Author

boegel commented Jul 5, 2017

@easybuilders/easybuild-framework-maintainers Green light by Travis, this is blocking several other PRs, please review.

@damianam
Copy link
Member

damianam commented Jul 5, 2017

lgtm. I'd merge it, but I don't have the rights yet :-/

@boegel
Copy link
Member Author

boegel commented Jul 5, 2017

@damianam OK, that's strange, I've assigned your write permissions, both individually and via the easybuild-framework maintainers team... :-/

@boegel
Copy link
Member Author

boegel commented Jul 5, 2017

@damianam image

@ocaisa
Copy link
Member

ocaisa commented Jul 5, 2017

I have the power!....trusting @damianam review

@ocaisa ocaisa merged commit c97807e into easybuilders:develop Jul 5, 2017
@boegel
Copy link
Member Author

boegel commented Jul 5, 2017

OK, problem was that the develop branch is a protected branch, where only I had push rights on...

I've removed that restriction (note to self: via https://github.com/easybuilders/easybuild-framework/settings/branches/develop)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants