added easyblock for oasyslsdyna #1363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
requested changes
May 22, 2018
| super(EB_OasysLSDyna, self).__init__(*args, **kwargs) | ||
|
|
||
| def install_step(self): | ||
| cmd = "echo -e \"%s\" | ./setup.csh" % ('\\n'.join(['FULL', 'Y', self.installdir, 'Y', 'N', 'Y', self.installdir, 'Y'])) |
There was a problem hiding this comment.
@mboisson Please use run_cmd_qa for this
| import shutil | ||
| import sys | ||
| import tempfile | ||
| from distutils.version import LooseVersion |
There was a problem hiding this comment.
@mboisson Please remove any imports you're not using, e.g. fileinput, LooseVersion, etc. Same below
|
|
||
| def __init__(self,*args,**kwargs): | ||
| """Enable building in install dir.""" | ||
| super(EB_OasysLSDyna, self).__init__(*args, **kwargs) |
There was a problem hiding this comment.
If you're not doing anything custom, you can drop the custom constructor.
| def make_module_extra(self): | ||
| """Correctly prepend PATH.""" | ||
|
|
||
| txt = super(EB_OasysLSDyna, self).make_module_extra() |
There was a problem hiding this comment.
Same here, not customization being done, so this method can be dropped
|
@mboisson Any progress on this? |
|
No, I have not had time to come back to this, especially changing to use run_qmd_qa. The other changes are trivial, but this one requires rerunning the recipe and fiddling with the right parameters to use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, but I would like comments anyway.