-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: update WRF and WPS to support version 4 #1563
Conversation
Both WRF and WPS saw quite some changes in version 4.0. This commit adapts the existing WPS and WRF easyblocks to accomodate them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 7, in from flake8.main.cli import main ModuleNotFoundError: No module named 'flake8'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 7, in from flake8.main.cli import main ModuleNotFoundError: No module named 'flake8'
avoid duplicate code for determining correct subdirectory in WRF/WPS easyblocks
@akesandgren Are you OK with current status on this? |
Still 2 things to change, chdir/remove_dir order and the comment about 2D tests |
sorry, forgot to push. should include everything now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@boegel I'm ok with this. It's your change requests that are blocking. |
Thanks a lot for the updates @andreas-h! |
Both WRF and WPS saw quite some changes in version 4.0. This commit
adapts the existing WPS and WRF easyblocks to accomodate them.