Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: update WRF and WPS to support version 4 #1563

Merged
merged 8 commits into from
Nov 7, 2018

Conversation

andreas-h
Copy link
Contributor

Both WRF and WPS saw quite some changes in version 4.0. This commit
adapts the existing WPS and WRF easyblocks to accomodate them.

Both WRF and WPS saw quite some changes in version 4.0.  This commit
adapts the existing WPS and WRF easyblocks to accomodate them.
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

easybuild/easyblocks/w/wps.py Outdated Show resolved Hide resolved
easybuild/easyblocks/w/wps.py Outdated Show resolved Hide resolved
easybuild/easyblocks/w/wps.py Outdated Show resolved Hide resolved
easybuild/easyblocks/w/wps.py Outdated Show resolved Hide resolved
easybuild/easyblocks/w/wps.py Outdated Show resolved Hide resolved
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

easybuild/easyblocks/w/wrf.py Outdated Show resolved Hide resolved
@boegel boegel added the update label Oct 31, 2018
@boegel boegel added this to the 3.8.0 milestone Oct 31, 2018
avoid duplicate code for determining correct subdirectory in WRF/WPS easyblocks
@boegel
Copy link
Member

boegel commented Nov 6, 2018

@akesandgren Are you OK with current status on this?

easybuild/easyblocks/w/wps.py Show resolved Hide resolved
easybuild/easyblocks/w/wrf.py Show resolved Hide resolved
@akesandgren
Copy link
Contributor

Still 2 things to change, chdir/remove_dir order and the comment about 2D tests

@andreas-h
Copy link
Contributor Author

sorry, forgot to push. should include everything now.

Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

@boegel I'm ok with this. It's your change requests that are blocking.

@boegel
Copy link
Member

boegel commented Nov 7, 2018

Thanks a lot for the updates @andreas-h!

@boegel boegel merged commit 8f98104 into easybuilders:develop Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants