Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update CP2K easyblock for recent versions (>= 7.0) #2069

Merged
merged 2 commits into from
Aug 14, 2020
Merged

update CP2K easyblock for recent versions (>= 7.0) #2069

merged 2 commits into from
Aug 14, 2020

Conversation

boegel
Copy link
Member

@boegel boegel commented May 28, 2020 •
edited
Loading

definitely needed for CP2K 7.1, but may need more work (all done now)...

@boegel boegel added the update label May 28, 2020
@boegel boegel added this to the next release (4.2.2?) milestone May 28, 2020
@boegel boegel mentioned this pull request Aug 6, 2020
Merged
@boegel boegel changed the title update CP2K easyblock for recent versions (>= 7.0) [WIP] update CP2K easyblock for recent versions (>= 7.0) Aug 13, 2020
@boegel
Copy link
Member Author

boegel commented Aug 13, 2020

I tested these changes with a bunch of existing CP2K easyconfigs, works like a charm:

  • CP2K-3.0-intel-2018a.eb.
  • CP2K-5.1-foss-2018a.eb
  • CP2K-6.1-foss-2019a.eb

migueldiascosta
migueldiascosta approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit 6cbbadb into easybuilders:develop Aug 14, 2020
@boegel boegel deleted the cp2k_update branch August 14, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees
No one assigned
Labels
update
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@boegel @migueldiascosta