Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure AOCC commands like clang/flang pick up GCCcore as GCC toolchain #2538

Merged
merged 5 commits into from
Sep 2, 2021
Merged

make sure AOCC commands like clang/flang pick up GCCcore as GCC toolchain #2538

merged 5 commits into from
Sep 2, 2021

Conversation

SebastianAchilles
Copy link
Member

(created using eb --new-pr)

@SebastianAchilles SebastianAchilles added this to the 4.x milestone Aug 7, 2021
@SebastianAchilles SebastianAchilles linked an issue Aug 7, 2021 that may be closed by this pull request
handle GCC toolchain selection in AOCC easyblock #2379
Closed
@SebastianAchilles
Copy link
Member Author

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

  • SUCCESS AOCC-2.3.0-GCCcore-10.2.0.eb
  • SUCCESS AOCC-2.3.0-GCCcore-9.3.0.eb
  • SUCCESS AOCC-3.0.0-GCCcore-10.2.0.eb
  • SUCCESS AOCC-3.0.0-GCCcore-10.3.0.eb
  • SUCCESS AOCC-3.1.0-GCCcore-10.2.0.eb
  • SUCCESS AOCC-3.1.0-GCCcore-10.3.0.eb

Build succeeded for 6 out of 6 (6 easyconfigs in total)
jrlogin11.jureca - Linux centos linux 8.3.2011, x86_64, AMD EPYC 7742 64-Core Processor, Python 3.6.8
See https://gist.github.com/16f3584e4b26e3b351f774ad00fe0239 for a full test report.

@SebastianAchilles SebastianAchilles linked an issue Aug 19, 2021 that may be closed by this pull request
AOCC fails in the linking step if system libquadmath is missing #2465
Closed
boegel
boegel requested changes Aug 29, 2021
View reviewed changes
easybuild/easyblocks/a/aocc.py Outdated
@@ -116,6 +117,9 @@ def make_module_extra(self):
txt += self.module_generator.set_environment('ASAN_SYMBOLIZER_PATH', asan_symbolizer_path)
# setting the AOCChome path
txt += self.module_generator.set_environment('AOCChome', self.installdir)
# make sure clang/flang picks up GCCcore as GCC toolchain
txt += self.module_generator.set_alias('clang', 'clang --gcc-toolchain=$EBROOTGCCCORE')
txt += self.module_generator.set_alias('flang', 'flang --gcc-toolchain=$EBROOTGCCCORE')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SebastianAchilles Maybe we should install an actual wrapper script rather than just defining an alias, since an alias is not inherited into a subshell?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, a wrapper script sounds like a good idea. I implemented the wrapper in 86aa43b and 235484c

@SebastianAchilles
Copy link
Member Author

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

  • SUCCESS AOCC-2.3.0-GCCcore-10.2.0.eb
  • SUCCESS AOCC-2.3.0-GCCcore-9.3.0.eb
  • SUCCESS AOCC-3.0.0-GCCcore-10.2.0.eb
  • SUCCESS AOCC-3.0.0-GCCcore-10.3.0.eb
  • SUCCESS AOCC-3.1.0-GCCcore-10.2.0.eb
  • SUCCESS AOCC-3.1.0-GCCcore-10.3.0.eb

Build succeeded for 6 out of 6 (6 easyconfigs in total)
jrlogin11.jureca - Linux centos linux 8.3.2011, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/340c2560fb7755d3b00f118f6e0621c0 for a full test report.

@boegel boegel mentioned this pull request Sep 2, 2021
Merged
boegel
boegel requested changes Sep 2, 2021
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SebastianAchilles Some trivial style fixes to make the code a bit like existing easyblocks in SebastianAchilles#1

@SebastianAchilles
Copy link
Member Author

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

  • SUCCESS AOCC-2.3.0-GCCcore-10.2.0.eb
  • SUCCESS AOCC-2.3.0-GCCcore-9.3.0.eb
  • SUCCESS AOCC-3.0.0-GCCcore-10.2.0.eb
  • SUCCESS AOCC-3.0.0-GCCcore-10.3.0.eb
  • SUCCESS AOCC-3.1.0-GCCcore-10.2.0.eb
  • SUCCESS AOCC-3.1.0-GCCcore-10.3.0.eb

Build succeeded for 6 out of 6 (6 easyconfigs in total)
jrlogin11.jureca - Linux centos linux 8.3.2011, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/f9b6a9a782186a8558ecd48dcf636815 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 2, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS AOCC-2.3.0-GCCcore-10.2.0.eb
  • SUCCESS AOCC-2.3.0-GCCcore-9.3.0.eb
  • SUCCESS AOCC-3.0.0-GCCcore-10.2.0.eb
  • SUCCESS AOCC-3.0.0-GCCcore-10.3.0.eb
  • SUCCESS AOCC-3.1.0-GCCcore-10.2.0.eb
  • SUCCESS AOCC-3.1.0-GCCcore-10.3.0.eb

Build succeeded for 6 out of 6 (6 easyconfigs in total)
node2641.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/31e498b7a933289b0b659065b31983d7 for a full test report.

@boegel boegel changed the title AOCC easyblock: make sure clang/flang picks up GCCcore as GCC toolchain make sure AOCC commands like clang/flang pick up GCCcore as GCC toolchain Sep 2, 2021
boegel
boegel approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 0fcc250 into easybuilders:develop Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.4.2
2 participants
@SebastianAchilles @boegel