Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update scipy easyblock to copy PKG-INFO to scipy-<version>.egg-info when installing with Meson/Ninja + add sanity check command using 'pip list' #2903

Merged
merged 2 commits into from
Mar 10, 2023
Merged

update scipy easyblock to copy PKG-INFO to scipy-<version>.egg-info when installing with Meson/Ninja + add sanity check command using 'pip list' #2903

merged 2 commits into from
Mar 10, 2023

Conversation

boegel
Copy link
Member

@boegel boegel commented Mar 9, 2023 •
edited
Loading

(created using eb --new-pr)

fixes #2901

@branfosj
Copy link
Member

branfosj commented Mar 9, 2023

We can use easybuilders/easybuild-easyconfigs#17456 to test that scipy is found in pip check.

@boegel boegel marked this pull request as draft March 9, 2023 09:01
@boegel boegel force-pushed the 20230309095256_new_pr_scipy branch from a39192a to d713ee9 Compare March 9, 2023 10:59
@boegel
update scipy easyblock to copy PKG-INFO to scipy-<version>.egg-info w…
de55fd4 
…hen installing with Meson/Ninja + enhance add sanity check command using 'pip list'
@boegel boegel force-pushed the 20230309095256_new_pr_scipy branch from d713ee9 to de55fd4 Compare March 9, 2023 11:09
@boegel boegel added the bug fix label Mar 9, 2023
@boegel boegel added this to the next release (4.7.1) milestone Mar 9, 2023
@boegel
Copy link
Member Author

boegel commented Mar 9, 2023

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS SciPy-bundle-2019.10-foss-2019b-Python-3.7.4.eb
  • SUCCESS SciPy-bundle-2020.11-foss-2020b.eb
  • SUCCESS SciPy-bundle-2020.11-foss-2020b-Python-2.7.18.eb
  • SUCCESS SciPy-bundle-2021.05-foss-2021a.eb
  • SUCCESS SciPy-bundle-2021.05-gomkl-2021a.eb
  • SUCCESS SciPy-bundle-2021.10-foss-2021b.eb
  • SUCCESS SciPy-bundle-2021.10-intel-2021b.eb
  • SUCCESS SciPy-bundle-2022.05-foss-2022a.eb
  • SUCCESS SciPy-bundle-2022.05-intel-2022a.eb
  • SUCCESS SciPy-bundle-2023.02-gfbf-2022b.eb

Build succeeded for 10 out of 10 (10 easyconfigs in total)
node3607.doduo.os - Linux RHEL 8.6, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/0111e3527d773886964aafe12719a274 for a full test report.

@branfosj @jfgrimm
correct directory to find PKG-INFO and improve sanity check test
bd9e693 
Co-authored-by: Jasper <65227842+jfgrimm@users.noreply.github.com>
@branfosj
Copy link
Member

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS SciPy-bundle-2023.02-gfbf-2022b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/cd03099a6f82d969667264426e7cda5c for a full test report.

@jfgrimm jfgrimm marked this pull request as ready for review March 10, 2023 12:39
@branfosj
Copy link
Member

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS SciPy-bundle-2019.10-foss-2019b-Python-3.7.4.eb
  • SUCCESS SciPy-bundle-2020.03-intel-2020a-Python-3.8.2.eb
  • SUCCESS SciPy-bundle-2020.11-foss-2020b.eb
  • SUCCESS SciPy-bundle-2021.10-foss-2021b.eb
  • SUCCESS SciPy-bundle-2022.05-foss-2022a.eb

Build succeeded for 5 out of 5 (5 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/fff0c5127b728c3cc25cb46640544a0a for a full test report.

@schiotz
Copy link
Contributor

schiotz commented Mar 10, 2023

Test report by @schiotz

Overview of tested easyconfigs (in order)

  • SUCCESS SciPy-bundle-2023.02-gfbf-2022b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
slid.fysik.dtu.dk - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2650 v4 @ 2.20GHz, Python 2.7.5
See https://gist.github.com/3a557b974680ce29ceff8cce9a3ac1fc for a full test report.

@boegelbot boegelbot mentioned this pull request Mar 10, 2023
Merged
4 tasks
@schiotz
Copy link
Contributor

schiotz commented Mar 10, 2023

I can confirm that with this fix, it is now possible to build packages that depend on scipy. In my case, scikit-learn.

@branfosj
Copy link
Member

Going in, thanks @boegel!

@branfosj branfosj merged commit fce1775 into easybuilders:develop Mar 10, 2023
@boegel boegel deleted the 20230309095256_new_pr_scipy branch March 10, 2023 14:54
@boegel boegel changed the title update scipy easyblock to copy PKG-INFO to scipy-<version>.egg-info when installing with Meson/Ninja + enhance add sanity check command using 'pip list' update scipy easyblock to copy PKG-INFO to scipy-<version>.egg-info when installing with Meson/Ninja + add sanity check command using 'pip list' Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@branfosj branfosj branfosj approved these changes

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.7.1
Development

Successfully merging this pull request may close these issues.

meson/ninja scipy install not producing egg / dist info
4 participants
@boegel @branfosj @schiotz @jfgrimm