replace run_cmd with run_shell_cmd in custom easyblock for Perl (perl.py)
#3162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
branfosj
approved these changes
Feb 5, 2024
|
Going in, thanks @bartoldeman! |
boegel
reviewed
Feb 7, 2024
| @@ -139,7 +139,7 @@ def test_step(self): | |||
| # specify locale to be used, to avoid that a handful of tests fail | |||
| cmd = "export LC_ALL=C && %s" % cmd | |||
|
|
|||
| run_cmd(cmd, log_all=False, log_ok=False, simple=False) | |||
| run_shell_cmd(cmd, fail_on_error=False) | |||
There was a problem hiding this comment.
Why are we ignoring non-zero exit codes here? That seems wrong...
@bartoldeman I understand that you're just translating from run_cmd to run_shell_cmd without changing behavior here, but this looks like a bug we should fix, no?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)