Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail on non-zero exit code in command to run Perl test suite #3170

Merged
merged 1 commit into from Feb 7, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Feb 7, 2024

(created using eb --new-pr)

#425 originally planned to allow a small number of failures in the Perl test suite. The failures were being caused by the locale and setting LC_ALL=C avoids these failures. However, the call to run_cmd was not updated to remove log_ok=False. So change it so that the tests failing causes EB to error.

@branfosj
Copy link
Member Author

branfosj commented Feb 7, 2024

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS Perl-5.32.0-GCCcore-10.2.0.eb
  • SUCCESS Perl-5.38.0-GCCcore-13.2.0.eb
  • SUCCESS Perl-5.34.1-GCCcore-11.3.0-minimal.eb
  • SUCCESS Perl-5.34.0-GCCcore-11.2.0.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
bear-pg0105u03b - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/cb14525ee7f7deb1a2cb89f9b89c754b for a full test report.

@boegel
Copy link
Member

boegel commented Feb 7, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Perl-5.30.2-GCCcore-9.3.0-minimal.eb
  • SUCCESS Perl-5.32.0-GCCcore-10.2.0-minimal.eb
  • SUCCESS Perl-5.32.1-GCCcore-10.3.0-minimal.eb
  • SUCCESS Perl-5.34.0-GCCcore-11.2.0-minimal.eb
  • SUCCESS Perl-5.34.1-GCCcore-11.3.0-minimal.eb
  • SUCCESS Perl-5.38.0.eb

Build succeeded for 6 out of 6 (6 easyconfigs in total)
node3587.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor, Python 3.6.8
See https://gist.github.com/boegel/02aa81336176d71ac033744d1eab441a for a full test report.

@branfosj
Copy link
Member Author

branfosj commented Feb 7, 2024

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS Perl-5.32.1-GCCcore-10.3.0.eb
  • SUCCESS Perl-5.32.1-GCCcore-10.3.0-minimal.eb
  • SUCCESS Perl-5.34.0-GCCcore-11.2.0.eb
  • SUCCESS Perl-5.34.0-GCCcore-11.2.0-minimal.eb
  • SUCCESS Perl-5.34.1-GCCcore-11.3.0.eb
  • SUCCESS Perl-5.34.1-GCCcore-11.3.0-minimal.eb
  • SUCCESS Perl-5.36.0-GCCcore-12.2.0.eb
  • SUCCESS Perl-5.36.0-GCCcore-12.2.0-minimal.eb
  • SUCCESS Perl-5.36.1-GCCcore-12.3.0.eb
  • SUCCESS Perl-5.36.1-GCCcore-13.1.0.eb
  • SUCCESS Perl-5.38.0.eb
  • SUCCESS Perl-5.38.0-GCCcore-13.2.0.eb
  • SUCCESS zlib-1.2.12-GCCcore-12.1.0.eb
  • SUCCESS help2man-1.49.2-GCCcore-12.1.0.eb
  • SUCCESS M4-1.4.19-GCCcore-12.1.0.eb
  • SUCCESS Bison-3.8.2-GCCcore-12.1.0.eb
  • SUCCESS flex-2.6.4-GCCcore-12.1.0.eb
  • SUCCESS binutils-2.38-GCCcore-12.1.0.eb
  • SUCCESS groff-1.22.4-GCCcore-12.1.0.eb
  • SUCCESS expat-2.4.8-GCCcore-12.1.0.eb
  • SUCCESS ncurses-6.3-GCCcore-12.1.0.eb
  • SUCCESS libreadline-8.1.2-GCCcore-12.1.0.eb
  • SUCCESS DB-18.1.40-GCCcore-12.1.0.eb
  • SUCCESS Perl-5.36.0-GCCcore-12.1.0.eb

Build succeeded for 24 out of 24 (13 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/7ef4bdec7c994d9bb43a4e572d35ffff for a full test report.

@boegel
Copy link
Member

boegel commented Feb 7, 2024

I'm testing this on aarch64 and ppc64le too, looking good, test reports coming up...

@boegel
Copy link
Member

boegel commented Feb 7, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Perl-5.38.0-GCCcore-13.2.0.eb
  • SUCCESS Perl-5.36.1-GCCcore-12.3.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
aarch64-neoverse-v1-node2.int.aws-rocky88-202310.eessi.io - Linux Rocky Linux 8.8, AArch64, ARM UNKNOWN (neoverse_n1), Python 3.6.8
See https://gist.github.com/boegel/681fa828652df4ab3b39573ebd32e264 for a full test report.

@boegel
Copy link
Member

boegel commented Feb 7, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Perl-5.30.2-GCCcore-9.3.0-minimal.eb
  • SUCCESS Perl-5.32.0-GCCcore-10.2.0-minimal.eb
  • SUCCESS Perl-5.32.1-GCCcore-10.3.0-minimal.eb
  • SUCCESS Perl-5.34.0-GCCcore-11.2.0-minimal.eb
  • SUCCESS Perl-5.34.1-GCCcore-11.3.0-minimal.eb
  • SUCCESS Perl-5.36.0-GCCcore-12.2.0-minimal.eb
  • SUCCESS Perl-5.38.0.eb

Build succeeded for 7 out of 7 (7 easyconfigs in total)
easybuild2.novalocal - Linux CentOS Stream 8, POWER, IBM pSeries (emulated by qemu) (power9le), Python 3.6.8
See https://gist.github.com/boegel/65c9b38d437bb7fb53cb3266cfbe1435 for a full test report.

@boegel boegel changed the title fail on error in the Perl tests fail on non-zero exit code in command to run Perl test suite Feb 7, 2024
@boegel boegel merged commit 55c6558 into easybuilders:5.0.x Feb 7, 2024
17 checks passed
@branfosj branfosj deleted the 20240207125436_new_pr_perl branch February 7, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants