Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid relying on system toolchain for Eigen build dep required by pybind11 #10098

Merged
merged 1 commit into from
Mar 17, 2020
Merged

avoid relying on system toolchain for Eigen build dep required by pybind11 #10098

merged 1 commit into from
Mar 17, 2020

Conversation

boegel
Copy link
Member

@boegel boegel commented Mar 17, 2020

(created using eb --new-pr)
Change to avoid that GCCcore/8.3.0 is also required for pybind11 installed with GCCcore/9.3.0 toolchain

@boegel boegel added update 2020a before 2020a is released and removed update labels Mar 17, 2020
@boegel
Copy link
Member Author

boegel commented Mar 17, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2491.golett.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/141808f4c711b0c5bebb307f8dc045f7 for a full test report.

@boegel boegel added the change label Mar 17, 2020
@boegel boegel added this to In progress in 2020a via automation Mar 17, 2020
@boegel boegel added this to the 2020a milestone Mar 17, 2020
@akesandgren
Copy link
Contributor

Test report by @akesandgren
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
skalman.hpc2n.umu.se - Linux ubuntu 18.04, Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz, Python 2.7.17
See https://gist.github.com/7b3c6b7f87ebd59a82d26db1be2dd4ac for a full test report.

@boegel
Copy link
Member Author

boegel commented Mar 17, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
generoso-3 - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/b599e9e11557b43b5db42efc8cc51ebd for a full test report.

akesandgren
akesandgren approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2020a automation moved this from In progress to Reviewer approved Mar 17, 2020
@akesandgren
Copy link
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 79710a6 into easybuilders:2020a Mar 17, 2020
2020a automation moved this from Reviewer approved to Done Mar 17, 2020
@boegel boegel deleted the 20200317141056_new_pr_pybind11243 branch March 17, 2020 13:29
@boegel boegel mentioned this pull request Mar 17, 2020
Closed
@boegel boegel mentioned this pull request Nov 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees
No one assigned
Labels
2020a before 2020a is released change
Projects
No open projects
2020a
  
Done
Milestone
2020a
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boegel @akesandgren