Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use is_generic_easyblock from filetools in test suite #11020

Merged
merged 1 commit into from
Jul 24, 2020
Merged

use is_generic_easyblock from filetools in test suite #11020

merged 1 commit into from
Jul 24, 2020

Conversation

Flamefire
Copy link
Contributor

This avoids the deprecation warnings on CI.

Seems like my autopep8 also found 2 overlong lines in that file. I'm inclined to keep that change.

@Flamefire
Copy link
Contributor Author

Deprecation introduced in easybuilders/easybuild-framework#3189 by @migueldiascosta

smoors
smoors approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
I ran the easyconfigs tests, and there are no extra failures/errors, so all should be good.

@smoors smoors added the bug fix label Jul 24, 2020
@smoors smoors added this to the next release (4.2.3?) milestone Jul 24, 2020
@smoors smoors merged commit 484cbbd into easybuilders:develop Jul 24, 2020
@Flamefire Flamefire deleted the fix_deprecated_is_generic_easyblock branch July 24, 2020 14:44
@boegel boegel changed the title Use is_generic_easyblock from filetools use is_generic_easyblock from filetools in test suite Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoors smoors smoors approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Flamefire @smoors