Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove --no-dist-info configuration option for SIP in recent PyQt5 easyconfigs #11307

Merged
merged 2 commits into from
Sep 18, 2020

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Sep 18, 2020

(created using eb --new-pr)

fix for #11304

Note that the source download location is problematic #11247

@branfosj
Copy link
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
bear-pg0211u03a.bear.cluster - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/61b67e2c4a03854b35038606764bc945 for a full test report.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added the bug fix label Sep 18, 2020
@Micket Micket added this to the next release (4.3.1) milestone Sep 18, 2020
@Micket
Copy link
Contributor

Micket commented Sep 18, 2020

Test report by @Micket
FAILED
Build succeeded for 2 out of 3 (3 easyconfigs in this PR)
hebbe-c1 - Linux centos linux 7.8.2003, x86_64, Intel Core Processor (Haswell, no TSX), Python 2.7.5
See https://gist.github.com/d1f6a659bf8ab8126c569381e771d401 for a full test report.

(it was just the downloading thing that failed as expected)

@branfosj
Copy link
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
bber0501u03a.bb2.cluster - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/2b80fc97649d9774c418db2dd671d3df for a full test report.

@Micket
Copy link
Contributor

Micket commented Sep 18, 2020

Going in, thanks @branfosj!

@Micket Micket merged commit b5cbb07 into easybuilders:develop Sep 18, 2020
@branfosj branfosj deleted the 20200918084026_new_pr_PyQt55121 branch September 18, 2020 16:00
@boegel boegel changed the title PyQt5: remove --no-dist-info remove --no-dist-info configuration option for SIP in recent PyQt5 easyconfigs Sep 22, 2020
@boegel boegel added the change label Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants