Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add coloc, Exact, lmom, gld, and DescTools extensions to R-4.0.0 #11587

Merged
merged 3 commits into from
Nov 3, 2020

Conversation

verdurin
Copy link
Member

@verdurin verdurin commented Oct 28, 2020

(created using eb --new-pr)
depends on #11586

@verdurin verdurin changed the title add coloc extenstion to R-4.0.0 add coloc extension to R-4.0.0 Oct 28, 2020
@verdurin verdurin changed the title add coloc extension to R-4.0.0 add coloc, Exact, lmom, gld, and DescTools extensions to R-4.0.0 Oct 28, 2020
@verdurin verdurin changed the title add coloc, Exact, lmom, gld, and DescTools extensions to R-4.0.0 add coloc, Exact, lmom, gld, and DescTools extensions to R-4.0.0 (WIP) Oct 28, 2020
@verdurin
Copy link
Member Author

I will probably alter this one so that it spreads the changes over both R and R-bundle-Bioconductor.

@lexming
Copy link
Contributor

lexming commented Oct 29, 2020

@verdurin this cannot depend on #11586 because R does not depend on R-bundle-Bioconductor. Is it the other way around maybe?

@lexming lexming added this to the 4.x milestone Oct 29, 2020
@boegel
Copy link
Member

boegel commented Nov 1, 2020

@boegelbot please test @ generoso
EB_ARGS="--skip --rebuild"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11587 EB_ARGS="--skip --rebuild" /apps/slurm/default/bin/sbatch --job-name test_PR_11587 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8207

Test results coming soon (I hope)...

- notification for comment with ID 720101045 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/f5ff85acb7c15ad6818836554aae87e3 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (not sure why this is still WIP)

@verdurin
Copy link
Member Author

verdurin commented Nov 1, 2020

@boegel yes, I think it's fine to merge now.

@verdurin verdurin changed the title add coloc, Exact, lmom, gld, and DescTools extensions to R-4.0.0 (WIP) add coloc, Exact, lmom, gld, and DescTools extensions to R-4.0.0 Nov 1, 2020
@boegel
Copy link
Member

boegel commented Nov 3, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3575.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/f3e5cf54bddab67ab24ff1c04e3564ca for a full test report.

@boegel
Copy link
Member

boegel commented Nov 3, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3401.kirlia.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/0d3b64c36d9533eec00a60015cb376ca for a full test report.

@boegel
Copy link
Member

boegel commented Nov 3, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3104.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/86d7a586b408c1b3d71baacf5810069f for a full test report.

@boegel
Copy link
Member

boegel commented Nov 3, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2407.golett.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/aca5ad870f72f4ad3073672466b015bc for a full test report.

@boegel
Copy link
Member

boegel commented Nov 3, 2020

Going in, thanks @verdurin!

@boegel boegel merged commit 16d9295 into easybuilders:develop Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants