Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{devel}[system/system] Flink v1.11.2 #11747

Merged
merged 4 commits into from Nov 27, 2020
Merged

{devel}[system/system] Flink v1.11.2 #11747

merged 4 commits into from Nov 27, 2020

Conversation

Falkor
Copy link
Contributor

@Falkor Falkor commented Nov 22, 2020

(created using eb --new-pr)

@Falkor
Copy link
Contributor Author

Falkor commented Nov 22, 2020

Test report by @ULHPC
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
iris-042 - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v4 @ 2.40GHz, Python 3.6.8
See https://gist.github.com/3d9e48d60ee2e14b84d0e5110b39b209 for a full test report.

@lexming
Copy link
Contributor

lexming commented Nov 24, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node381.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/81ae306ed1e0cfc3c664a45eb7fcced4 for a full test report.

lexming
lexming requested changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, it works well. I would like to make a minor improvement regarding the sanity checks. Please consider my suggestions below

easybuild/easyconfigs/f/Flink/Flink-1.11.2-bin-scala_2.11.eb Outdated Show resolved Hide resolved
easybuild/easyconfigs/f/Flink/Flink-1.11.2-bin-scala_2.11.eb Outdated Show resolved Hide resolved
easybuild/easyconfigs/f/Flink/Flink-1.11.2-bin-scala_2.11.eb Outdated Show resolved Hide resolved
@lexming lexming added the new label Nov 26, 2020
@lexming lexming added this to the 4.x milestone Nov 26, 2020
Sebastien Varrette and others added 3 commits November 26, 2020 15:00
@lexming
Update easybuild/easyconfigs/f/Flink/Flink-1.11.2-bin-scala_2.11.eb
4a7b15c 
Co-authored-by: Alex Domingo <alex.domingo.toro@vub.be>
@lexming
Update easybuild/easyconfigs/f/Flink/Flink-1.11.2-bin-scala_2.11.eb
5464153 
Co-authored-by: Alex Domingo <alex.domingo.toro@vub.be>
@lexming
Update easybuild/easyconfigs/f/Flink/Flink-1.11.2-bin-scala_2.11.eb
353d278 
Co-authored-by: Alex Domingo <alex.domingo.toro@vub.be>
@lexming
Copy link
Contributor

lexming commented Nov 27, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node378.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/3320f57efc3dfc8a500d6ffc4de4816f for a full test report.

@lexming
Copy link
Contributor

lexming commented Nov 27, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node128.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/94262fc47b20c9eb67f3187fa1c3f468 for a full test report.

lexming
lexming approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming lexming modified the milestones: 4.x, 4.3.2 (next release) Nov 27, 2020
@lexming
Copy link
Contributor

lexming commented Nov 27, 2020

Going in, thanks @Falkor !

@lexming lexming merged commit e54ebc4 into easybuilders:develop Nov 27, 2020
@Falkor Falkor deleted the 20201122171712_new_pr_Flink1112 branch December 3, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexming lexming lexming approved these changes

Assignees
No one assigned
Labels
new
Projects
None yet
Milestone
4.3.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Falkor @lexming