-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't disable optarch for Clang 11.0.0 #11814
don't disable optarch for Clang 11.0.0 #11814
Conversation
@boegelbot please test @ generoso EB_ARGS="--include-easyblocks-from-pr 2264" |
This needs easybuilders/easybuild-easyblocks#2264 |
@bartoldeman: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... - notification for comment with ID 738154656 processed Message to humans: this is just bookkeeping information for me, |
@bartoldeman Any comment on the issue with optarch? Is the comment simply wrong? |
@Micket the comment is obsolete, it's copied from an earlier version but I had no issue building it with that line removed.
but has never been checked after I guess |
relevant commit for optarch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (test build is going to take ages)
Test report by @Micket |
I was wrong, it was very quick. Hmm
Looks fine to me, so I'm not sure what goes wrong here. |
@Micket perhaps it needs a build dep on swig, I my log I have:
perhaps you picked up an OS SWIG that is now too old. |
I added the SWIG builddep because it's a good idea in any case. |
Co-authored-by: Mikael Öhman <micketeer@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test report by @boegelbot |
@boegelbot please test @ generoso EB_ARGS="--include-easyblocks-from-pr 2264" |
I asked the always friendly looking bot to do another build with the SWIG builddep |
@bartoldeman: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... - notification for comment with ID 738357106 processed Message to humans: this is just bookkeeping information for me, |
Test report by @Micket |
@bartoldeman So.. Python turns out to be a runtime dependency;
|
So, options as i see them
I assume python dep comes from SWIG? If not, then, well, option 3 just disappears. |
Maybe 2 (seperate lldb) is not too hard. Can give that a go. |
Test report by @boegelbot |
#11822 does LLDB now. Though we can still remove the optarch line I guess. |
@bartoldeman what's the latest on this one? |
still the same, I forgot about this one :(. Will adjust |
Only keep the optarch change
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... - notification for comment with ID 754522127 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegel |
Test report by @boegel |
Test report by @verdurin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
Test report by @boegelbot |
Going in, thanks @bartoldeman! |
(created using
eb --new-pr
)