Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cuby 4 #1258

Merged
merged 2 commits into from
Jan 16, 2015
Merged

Cuby 4 #1258

merged 2 commits into from
Jan 16, 2015

Conversation

hajgato
Copy link
Collaborator

@hajgato hajgato commented Dec 16, 2014

depends on #1233

@hpcugentbot
Copy link
Contributor

Automatic reply from Jenkins: Can I test this?

to their results, making it easy to create new computational
protocols by combining existing blocks of the framework."""

toolchain = {'name': 'dummy', 'version': 'dummy'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the dummy toolchain? Remember, if the version is also dummy, dependencies are not loaded

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I would even go as far as using a non-dummy toolchain here, since you're picking a toolchain anyway when specifying the dependency

that'll make it clear that this module will also result in loaded intel/2014b

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not rally mind to add the toolchain, but anyway, it is a packed binary. So in theory it does not need a toochain. This is why I have chosen to add a dummy toolchain. Anyway, I will put intel/2014b.

@wpoely86
Copy link
Member

ok to test

@hpcugentbot
Copy link
Contributor

Test FAILed.

@boegel
Copy link
Member

boegel commented Jan 15, 2015

Jenkins: test this please

@hpcugentbot
Copy link
Contributor

Test PASSed.

@hpcugentbot
Copy link
Contributor

Test PASSed.

@boegel
Copy link
Member

boegel commented Jan 16, 2015

@hajgato: since there's no 'proper' version, should we add a checksum for the source tarball?

@boegel
Copy link
Member

boegel commented Jan 16, 2015

@hagato informed me that licensing info is included in the tarball, so checksum is not an option

Fine, merging this in then, looks fine.

boegel added a commit that referenced this pull request Jan 16, 2015
@boegel boegel merged commit 9978c5f into easybuilders:develop Jan 16, 2015
@hajgato hajgato deleted the cuby4 branch October 9, 2015 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants