-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cuby 4 #1258
Cuby 4 #1258
Conversation
Automatic reply from Jenkins: Can I test this? |
to their results, making it easy to create new computational | ||
protocols by combining existing blocks of the framework.""" | ||
|
||
toolchain = {'name': 'dummy', 'version': 'dummy'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the dummy
toolchain? Remember, if the version is also dummy
, dependencies are not loaded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I would even go as far as using a non-dummy toolchain here, since you're picking a toolchain anyway when specifying the dependency
that'll make it clear that this module will also result in loaded intel/2014b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not rally mind to add the toolchain, but anyway, it is a packed binary. So in theory it does not need a toochain. This is why I have chosen to add a dummy toolchain. Anyway, I will put intel/2014b.
ok to test |
Test FAILed. |
Jenkins: test this please |
Test PASSed. |
Test PASSed. |
@hajgato: since there's no 'proper' version, should we add a checksum for the source tarball? |
@hagato informed me that licensing info is included in the tarball, so checksum is not an option Fine, merging this in then, looks fine. |
depends on #1233