Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio}[foss/2020a] MetaPhlAn v3.0.9 w/ Python 3.8.2 #12917

Merged

Conversation

manifestoso
Copy link
Contributor

(created using eb --new-pr)

@manifestoso
Copy link
Contributor Author

manifestoso commented May 21, 2021

Build success dep on #12913, #12915 #12916

@boegelbot

This comment has been minimized.

@boegelbot

This comment has been minimized.

@branfosj branfosj added this to the 4.x milestone May 21, 2021
@manifestoso
Copy link
Contributor Author

@branfosj can we rebuild this one. Thx

@branfosj
Copy link
Member

@branfosj can we rebuild this one. Thx

Can you run eb --sync-pr 12917, which will update the branch in this PR with the dependencies that have now been merged.

@boegelbot

This comment has been minimized.

@manifestoso
Copy link
Contributor Author

@branfosj can we rebuild this one. Thx

Can you run eb --sync-pr 12917, which will update the branch in this PR with the dependencies that have now been merged.

No worries, done. Thx

@verdurin
Copy link
Member

@robqiao could you address the test failures and see if it can use the slightly order version of MAFFT?

@manifestoso
Copy link
Contributor Author

@robqiao could you address the test failures and see if it can use the slightly order version of MAFFT?

@verdurin @branfosj No worries, fixed now.

@easybuilders easybuilders deleted a comment from boegelbot Jun 6, 2021
@easybuilders easybuilders deleted a comment from boegelbot Jun 6, 2021
@boegel
Copy link
Member

boegel commented Jun 6, 2021

Test report by @boegel
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
node2617.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/b833b817999a3bf277106df397ea1821 for a full test report.

@boegel
Copy link
Member

boegel commented Jun 6, 2021

@robqiao pip check fails in sanity check because several dependencies are missing? See test report...

@manifestoso
Copy link
Contributor Author

deps on #14326

@boegelbot

This comment has been minimized.

@manifestoso
Copy link
Contributor Author

manifestoso commented Dec 12, 2021

@verdurin @smoors @lexming proofread this PR?

@manifestoso
Copy link
Contributor Author

manifestoso commented Dec 15, 2021

deps on PR #14562

@manifestoso
Copy link
Contributor Author

deps on #14326

@manifestoso
Copy link
Contributor Author

Test report by @robqiao
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
hpc-head01 - Linux UNKNOWN UNKNOWN, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, Python 3.9.6
See https://gist.github.com/1c6988178874c312b58c523c517cd117 for a full test report.

@boegelbot

This comment has been minimized.

@manifestoso manifestoso marked this pull request as draft December 15, 2021 11:16
@manifestoso manifestoso marked this pull request as ready for review December 17, 2021 03:30
@lexming
Copy link
Contributor

lexming commented Dec 17, 2021

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=12917 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_12917 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7512

Test results coming soon (I hope)...

- notification for comment with ID 997086048 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/00db40d385cd79ce30c52a10c2bf2340 for a full test report.

@lexming
Copy link
Contributor

lexming commented Dec 17, 2021

Test report by @lexming
SUCCESS
Build succeeded for 4 out of 4 (1 easyconfigs in total)
node301.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/8042807adb2b0677c2fb854e33271d59 for a full test report.

@lexming
Copy link
Contributor

lexming commented Dec 17, 2021

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=12917 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_12917 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7513

Test results coming soon (I hope)...

- notification for comment with ID 997090778 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/852a747db293c058dd395742afe3be9b for a full test report.

Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @manifestoso . I just made a little fix to the sanity checks, as long as you already check for files inside bin and lib ther is no need to explicitly check for those folders. In this case, you already check for the executables inside bin and since MetaPhlAn is a Python package we must have a site-packages inside lib.

LGTM

@lexming lexming modified the milestones: 4.x, 5.0, next release (4.5.2?) Dec 17, 2021
@lexming
Copy link
Contributor

lexming commented Dec 17, 2021

Going in, thanks @manifestoso !

@lexming lexming merged commit e48194d into easybuilders:develop Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants