-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{bio}[foss/2020a] MetaPhlAn v3.0.9 w/ Python 3.8.2 #12917
{bio}[foss/2020a] MetaPhlAn v3.0.9 w/ Python 3.8.2 #12917
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@branfosj can we rebuild this one. Thx |
Can you run |
This comment has been minimized.
This comment has been minimized.
…asyconfigs into 20210521143242_new_pr_MetaPhlAn309
No worries, done. Thx |
@robqiao could you address the test failures and see if it can use the slightly order version of |
Test report by @boegel |
@robqiao |
deps on #14326 |
…asyconfigs into 20210521143242_new_pr_MetaPhlAn309
This comment has been minimized.
This comment has been minimized.
…asyconfigs into 20210521143242_new_pr_MetaPhlAn309
deps on PR |
|
Test report by @robqiao |
This comment has been minimized.
This comment has been minimized.
…asyconfigs into 20210521143242_new_pr_MetaPhlAn309
@boegelbot: please test @ generoso |
@lexming: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 997086048 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @lexming |
@boegelbot: please test @ generoso |
@lexming: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 997090778 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @manifestoso . I just made a little fix to the sanity checks, as long as you already check for files inside bin
and lib
ther is no need to explicitly check for those folders. In this case, you already check for the executables inside bin
and since MetaPhlAn is a Python package we must have a site-packages
inside lib
.
LGTM
Going in, thanks @manifestoso ! |
(created using
eb --new-pr
)