Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{vis}[foss/2020b,intel/2020b] VisPy v0.6.6 w/ Python 3.8.6 #13468

Merged
merged 1 commit into from
Jul 31, 2021
Merged

{vis}[foss/2020b,intel/2020b] VisPy v0.6.6 w/ Python 3.8.6 #13468

merged 1 commit into from
Jul 31, 2021

Conversation

SimonPinches
Copy link
Contributor

(created using eb --new-pr)

@robert-mijakovic
Copy link
Contributor

AssertionError: 'source_urls' should not be defined in exts_default_options when using the default value in VisPy-0.6.6-foss-2020b.eb 'source_urls' should not be defined in exts_default_options when using the default value in VisPy-0.6.6-intel-2020b.eb

@SimonPinches SimonPinches force-pushed the 20210721151625_new_pr_VisPy066 branch from e8b2e81 to 5f93b9d Compare July 28, 2021 12:56
@SimonPinches
Copy link
Contributor Author

@robert-mijakovic I've fixed the error mentioned (I think!).

@lexming
Copy link
Contributor

lexming commented Jul 29, 2021

Test report by @lexming
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in total)
node375.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/b8ac4e94e60d21b5537849082e3a86f9 for a full test report.

@lexming lexming added the new label Jul 31, 2021
@lexming lexming added this to the next release (4.4.2?) milestone Jul 31, 2021
lexming
lexming approved these changes Jul 31, 2021
View reviewed changes
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Contributor

lexming commented Jul 31, 2021

Going in, thanks @SimonPinches !

@lexming lexming merged commit 4e3554a into easybuilders:develop Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexming lexming lexming approved these changes

Assignees
No one assigned
Labels
new
Projects
None yet
Milestone
4.4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonPinches @robert-mijakovic @lexming