Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{math}[foss/2020b] gmsh v4.8.4 w/ Python 3.8.6 #13905

Closed
wants to merge 105 commits into from

Conversation

Falkor
Copy link
Contributor

@Falkor Falkor commented Sep 3, 2021

(created using eb --new-pr)

Sebastien Varrette and others added 30 commits April 9, 2020 15:49
@Falkor
Copy link
Contributor Author

Falkor commented Sep 3, 2021

Test report by @ULHPC
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
aion-0027 - Linux RHEL 8.3, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/2beb7f7bfa9edafa964bfb4ec56185e3 for a full test report.

@Falkor
Copy link
Contributor Author

Falkor commented Sep 3, 2021

I don't know if adding the dependant EB from #13904 was pertinent -- it was to ensure you are able to reproduce the build from this sole PR. Feel free to remove SLEPc-3.14.2-foss-2020b.eb from this PR to keep both managements separated.

@boegelbot
Copy link
Collaborator

@Falkor: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/1199561888
Output from first failing test suite run:

======================================================================
Merge base for develop and HEAD: 864ed29c68385b6b3c6084108d0c07fe041a0474
FAIL: test_pr_python_packages (test.easyconfigs.easyconfigs.EasyConfigTest)
Merge base for develop and HEAD: 864ed29c68385b6b3c6084108d0c07fe041a0474
Several checks for easyconfigs that install (bundles of) Python packages.

----------------------------------------------------------------------
List of added easyconfig files in this PR:
Traceback (most recent call last):
	gmsh-4.8.4-foss-2020b-Python-3.8.6.eb
  File "test/easyconfigs/easyconfigs.py", line 957, in test_pr_python_packages
	SLEPc-3.14.2-foss-2020b.eb
    self.fail('\n'.join(failing_checks))
AssertionError: '-Python-%(pyver)s' should no longer be included in versionsuffix in gmsh-4.8.4-foss-2020b-Python-3.8.6.eb

----------------------------------------------------------------------
Ran 13272 tests in 488.649s

FAILED (failures=1)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice you me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@boegel boegel added the update label Sep 4, 2021
@boegel boegel added this to the 4.x milestone Sep 4, 2021
@boegel
Copy link
Member

boegel commented Sep 4, 2021

@Falkor It's better not to merge PRs together like you did, but instead just mark that another PR is required to be merged first by referring to it in the PR description, like:

requires #13904

We can re-trigger the tests once the other PR has been merged.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also sync with develop branch now that #13904 is merged (you can use --sync-pr-with-develop 13905)


name = 'gmsh'
version = '4.8.4'
versionsuffix = '-Python-%(pyver)s'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Falkor Please drop the versionsuffix, no longer needed for Python 3 in the 2020b generation of easyconfigs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel Thanks for the comments, I corrected accordingly. Shall I rename also the EB to gmsh-4.8.4-foss-2020b.eb ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, big mess and mistake in the EB file to correct -- sry about that, I'll correct it asap

Sebastien Varrette added 6 commits September 5, 2021 13:54
@easybuilders easybuilders deleted a comment from boegelbot Sep 5, 2021
@@ -16,13 +16,11 @@ builddependencies = [
('binutils', '2.34'),
('CMake', '3.16.4'),
]
# build twice, once for static, once for shared libraries
configopts = ['', ' -DBUILD_SHARED_LIBS=ON ']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Falkor This looks like an unintended change that slipped in somehow?

Copy link
Contributor Author

@Falkor Falkor Sep 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I have it also from official EB 4.4.1 ? -- googletest-1.10.0-GCCcore-9.3.0.eb

$ eb -S googletest-1.10.0
CFGS1=/path/to/software/EasyBuild/4.4.1/easybuild/easyconfigs/g/googletest
CFGS2=/path/to/github.com/ULHPC/easybuild-easyconfigs/easybuild/easyconfigs/g/googletest
 * $CFGS1/googletest-1.10.0-GCCcore-8.3.0.eb
 * $CFGS1/googletest-1.10.0-GCCcore-9.3.0.eb
 * $CFGS1/googletest-1.10.0-GCCcore-10.2.0.eb
 * $CFGS2/googletest-1.10.0-GCCcore-8.3.0.eb
 * $CFGS2/googletest-1.10.0-GCCcore-9.3.0.eb
 * $CFGS2/googletest-1.10.0-GCCcore-10.2.0.eb

Then:

# force check from 4.4.1 
CFGS1=/path/to/software/EasyBuild/4.4.1/easybuild/easyconfigs/g/googletest
$ cat $CFGS1/g/googletest/googletest-1.10.0-GCCcore-9.3.0.eb
easyblock = 'CMakeMake'

name = 'googletest'
version = '1.10.0'

homepage = 'https://github.com/google/googletest'
description = "Google's framework for writing C++ tests on a variety of platforms"

toolchain = {'name': 'GCCcore', 'version': '9.3.0'}

source_urls = ['https://github.com/google/googletest/archive/']
sources = ['release-%(version)s.tar.gz']
checksums = ['9dc9157a9a1551ec7a7e43daea9a694a0bb5fb8bec81235d8a1e6ef64c716dcb']

builddependencies = [
    ('binutils', '2.34'),
    ('CMake', '3.16.4'),
]
# build twice, once for static, once for shared libraries
configopts = ['', ' -DBUILD_SHARED_LIBS=ON ']
separate_build_dir = True

sanity_check_paths = {
    'files': ['lib/lib%s.%s' % (local_lib, local_ext) for local_lib in ['gmock', 'gmock_main', 'gtest', 'gtest_main']
              for local_ext in ['a', SHLIB_EXT]],
    'dirs': ['include/gmock', 'include/gtest'],
}

moduleclass = 'tools'

@Falkor
Copy link
Contributor Author

Falkor commented Mar 30, 2022

It was kept in googletest-1.10.0-GCCcore-10.2.0.eb. I guess the requested change can be dropped ?

@Falkor
Copy link
Contributor Author

Falkor commented Apr 14, 2022

@boegel you confirm?

@boegel
Copy link
Member

boegel commented Jan 13, 2024

closing this since foss/2020b is deprecated, see https://docs.easybuild.io/policies/toolchains

@Falkor Sorry for not getting back to this...

We also have easyconfigs for more recent versions of gmsh already

@boegel boegel closed this Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants