-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{math}[foss/2020b] gmsh v4.8.4 w/ Python 3.8.6 #13905
{math}[foss/2020b] gmsh v4.8.4 w/ Python 3.8.6 #13905
Conversation
Test report by @ULHPC |
I don't know if adding the dependant EB from #13904 was pertinent -- it was to ensure you are able to reproduce the build from this sole PR. Feel free to remove |
@Falkor: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/1199561888
bleep, bloop, I'm just a bot (boegelbot v20200716.01) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also sync with develop
branch now that #13904 is merged (you can use --sync-pr-with-develop 13905
)
|
||
name = 'gmsh' | ||
version = '4.8.4' | ||
versionsuffix = '-Python-%(pyver)s' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Falkor Please drop the versionsuffix
, no longer needed for Python 3 in the 2020b
generation of easyconfigs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boegel Thanks for the comments, I corrected accordingly. Shall I rename also the EB to gmsh-4.8.4-foss-2020b.eb
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad, big mess and mistake in the EB file to correct -- sry about that, I'll correct it asap
Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
…2020b Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
… in the 2020b" This reverts commit 785fd02.
…quired Signed-off-by: Sebastien Varrette <Sebastien.Varrette@uni.lu>
@@ -16,13 +16,11 @@ builddependencies = [ | |||
('binutils', '2.34'), | |||
('CMake', '3.16.4'), | |||
] | |||
# build twice, once for static, once for shared libraries | |||
configopts = ['', ' -DBUILD_SHARED_LIBS=ON '] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Falkor This looks like an unintended change that slipped in somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I have it also from official EB 4.4.1 ? -- googletest-1.10.0-GCCcore-9.3.0.eb
$ eb -S googletest-1.10.0
CFGS1=/path/to/software/EasyBuild/4.4.1/easybuild/easyconfigs/g/googletest
CFGS2=/path/to/github.com/ULHPC/easybuild-easyconfigs/easybuild/easyconfigs/g/googletest
* $CFGS1/googletest-1.10.0-GCCcore-8.3.0.eb
* $CFGS1/googletest-1.10.0-GCCcore-9.3.0.eb
* $CFGS1/googletest-1.10.0-GCCcore-10.2.0.eb
* $CFGS2/googletest-1.10.0-GCCcore-8.3.0.eb
* $CFGS2/googletest-1.10.0-GCCcore-9.3.0.eb
* $CFGS2/googletest-1.10.0-GCCcore-10.2.0.eb
Then:
# force check from 4.4.1
CFGS1=/path/to/software/EasyBuild/4.4.1/easybuild/easyconfigs/g/googletest
$ cat $CFGS1/g/googletest/googletest-1.10.0-GCCcore-9.3.0.eb
easyblock = 'CMakeMake'
name = 'googletest'
version = '1.10.0'
homepage = 'https://github.com/google/googletest'
description = "Google's framework for writing C++ tests on a variety of platforms"
toolchain = {'name': 'GCCcore', 'version': '9.3.0'}
source_urls = ['https://github.com/google/googletest/archive/']
sources = ['release-%(version)s.tar.gz']
checksums = ['9dc9157a9a1551ec7a7e43daea9a694a0bb5fb8bec81235d8a1e6ef64c716dcb']
builddependencies = [
('binutils', '2.34'),
('CMake', '3.16.4'),
]
# build twice, once for static, once for shared libraries
configopts = ['', ' -DBUILD_SHARED_LIBS=ON ']
separate_build_dir = True
sanity_check_paths = {
'files': ['lib/lib%s.%s' % (local_lib, local_ext) for local_lib in ['gmock', 'gmock_main', 'gtest', 'gtest_main']
for local_ext in ['a', SHLIB_EXT]],
'dirs': ['include/gmock', 'include/gtest'],
}
moduleclass = 'tools'
It was kept in |
@boegel you confirm? |
closing this since @Falkor Sorry for not getting back to this... We also have easyconfigs for more recent versions of |
(created using
eb --new-pr
)