-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop tcmalloc from SymEngine as it causes crashes with scipy #14119
Drop tcmalloc from SymEngine as it causes crashes with scipy #14119
Conversation
Test report by @Micket |
Test report by @lexming |
@boegelbot please test @ generoso |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Micket Why not add python -c "import symengine; import scipy.fft._pocketfft"
as a sanity check command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm the bug and the fix.
LGTM
SciPy isn't actually a dependency here. |
Ah, ok... Nevermind then. :) |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 942721363 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Going in, thanks @Micket! |
Test report by @boegel |
(created using
eb --new-pr
)Use of tcmalloc causes some problems with SymEngine and SciPy-bundle
crashes. tcmalloc thinks it's a double free, so, either a bug in _pocketfft, or a but in tcmalloc I would guess. I can reproduce this with foss 2020b as well.
Since I don't know if there is a real bug in pocketfft, I propose to just drop gperftools from SymEngine instead.
(this particular bug is indirectly triggered by Qiskit 0.29 that i'm trying to add)