Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{data}[foss/2020b] nnU-Net v1.7.0 (+ dependencies) #14249

Merged

Conversation

deniskristak
Copy link
Collaborator

@deniskristak deniskristak commented Oct 29, 2021

adding easyconfigs: tifffile-2021.8.30-foss-2020b.eb, unittest2-1.1.0-foss-2020b.eb, SimpleITK-2.1.0-foss-2020b.eb, requests-2.26.0-foss-2020b.eb, batchgenerators-0.23-foss-2020b.eb, Lua-5.3.5-GCCcore-10.2.0.eb

edit (by @boegel): requires #14246 (dependencies for imagecodecs) + #14247 (imagecodecs)

deniskristak added 2 commits October 29, 2021 15:13
…-foss-2020b.eb, SimpleITK-2.1.0-foss-2020b.eb, requests-2.26.0-foss-2020b.eb, batchgenerators-0.23-foss-2020b.eb, Lua-5.3.5-GCCcore-10.2.0.eb
Micket
Micket previously requested changes Oct 29, 2021
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A general comment; having to many paths can be a performance problem, so, we often opt to bundle simple things like requests into the stuff that needs it rather than having another package with another PYTHONPATH. unittest2, requests, comes to mind here. I'm not saying we have to do this here, but, we need to keep this in mind, because if we never do it, it becomes an increasing problem

easybuild/easyconfigs/n/nnUNet/nnUNet-1.7.0-foss-2020b.eb Outdated Show resolved Hide resolved
# This file is an EasyBuild reciPY as per https://github.com/easybuilders/easybuild
# Updated: Denis Kristak
name = 'Lua'
version = '5.3.5'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the slight downgrade to 5.3.5 from 5.4.2 necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually yes...when installing with 5.4, we're getting Lua version 5.3 is required for SimpleITK_LUA_EXECUTABLE_VERSION.

@deniskristak
Copy link
Collaborator Author

@Micket i think this EC and it's deps are ready to be merged (merge this one last):

#14247 -> second to merge
#14246 -> first to merge

@boegel boegel added this to the 4.x milestone Nov 9, 2021
@easybuilders easybuilders deleted a comment from boegelbot Nov 9, 2021
@easybuilders easybuilders deleted a comment from boegelbot Nov 9, 2021
@easybuilders easybuilders deleted a comment from boegelbot Nov 9, 2021
@easybuilders easybuilders deleted a comment from boegelbot Nov 9, 2021
@boegel boegel changed the title adding nnUNet and it's deps {data}[foss/2020b] nnU-Net v1.7.0 (+ dependencies) Nov 9, 2021
@easybuilders easybuilders deleted a comment from boegelbot Nov 9, 2021
@boegel boegel dismissed Micket’s stale review November 9, 2021 21:35

requested changes made

@boegel
Copy link
Member

boegel commented Nov 9, 2021

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14249 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14249 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7251

Test results coming soon (I hope)...

- notification for comment with ID 964586964 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
cnx2 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/06953747e71f83fc098ff8bff8269b3d for a full test report.

@boegel
Copy link
Member

boegel commented Nov 9, 2021

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
node3103.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/d3dbeb8a3c53ab81a0f3257dd2ceec9e for a full test report.

@boegel
Copy link
Member

boegel commented Nov 10, 2021

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
node3518.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/cd3500322b3f291b309175400e34239e for a full test report.

@boegel
Copy link
Member

boegel commented Nov 10, 2021

Going in, thanks @deniskristak!

@boegel boegel merged commit c25e68a into easybuilders:develop Nov 10, 2021
@boegel boegel modified the milestones: 4.x, 4.5.1 Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants