-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{data}[foss/2020b] nnU-Net v1.7.0 (+ dependencies) #14249
{data}[foss/2020b] nnU-Net v1.7.0 (+ dependencies) #14249
Conversation
…-foss-2020b.eb, SimpleITK-2.1.0-foss-2020b.eb, requests-2.26.0-foss-2020b.eb, batchgenerators-0.23-foss-2020b.eb, Lua-5.3.5-GCCcore-10.2.0.eb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A general comment; having to many paths can be a performance problem, so, we often opt to bundle simple things like requests
into the stuff that needs it rather than having another package with another PYTHONPATH. unittest2, requests, comes to mind here. I'm not saying we have to do this here, but, we need to keep this in mind, because if we never do it, it becomes an increasing problem
# This file is an EasyBuild reciPY as per https://github.com/easybuilders/easybuild | ||
# Updated: Denis Kristak | ||
name = 'Lua' | ||
version = '5.3.5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the slight downgrade to 5.3.5 from 5.4.2 necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually yes...when installing with 5.4, we're getting Lua version 5.3 is required for SimpleITK_LUA_EXECUTABLE_VERSION.
added accidentaly
added accidentaly
removing old file
…impleITK (and MedPy + nnU-Net)
…oss/2020b toolchain
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 964586964 processed Message to humans: this is just bookkeeping information for me, |
… included must be used since double-to-string.h is required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test report by @boegelbot |
Test report by @boegel |
Test report by @boegel |
Going in, thanks @deniskristak! |
adding easyconfigs: tifffile-2021.8.30-foss-2020b.eb, unittest2-1.1.0-foss-2020b.eb, SimpleITK-2.1.0-foss-2020b.eb, requests-2.26.0-foss-2020b.eb, batchgenerators-0.23-foss-2020b.eb, Lua-5.3.5-GCCcore-10.2.0.eb
edit (by @boegel): requires
#14246(dependencies for imagecodecs) +#14247(imagecodecs)