Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable building of Python bindings for tbb 2020.3 #14434

Conversation

zarybnicky
Copy link
Contributor

@zarybnicky zarybnicky commented Nov 25, 2021

(created using eb --new-pr)

requires easybuilders/easybuild-easyblocks#2626

@boegel boegel changed the title tbb: build tbb4python bindings enable building of Python bindings for tbb 2020.3 Nov 25, 2021
@boegel boegel added this to the next release (4.5.1?) milestone Nov 25, 2021
@boegel
Copy link
Member

boegel commented Nov 25, 2021

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 2626"

@boegel
Copy link
Member

boegel commented Nov 25, 2021

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2626
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2620.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/9ba46953f2301852dad041b5775360de for a full test report.

@boegel
Copy link
Member

boegel commented Nov 25, 2021

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2626
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3501.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/6e4d2ef621567db958f0094dcaaab7ca for a full test report.

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14434 EB_ARGS="--include-easyblocks-from-pr 2626" /opt/software/slurm/bin/sbatch --job-name test_PR_14434 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7349

Test results coming soon (I hope)...

- notification for comment with ID 979458981 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2626
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/f347c4a8530c831c054ac429d12d2669 for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Nov 25, 2021
@boegelbot
Copy link
Collaborator

@zarybnicky: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/1505088305
Output from first failing test suite run:

Merge base for develop and HEAD: 7d013725c19ad640fff5f9b921f37253ffca5131
======================================================================
Merge base for develop and HEAD: 7d013725c19ad640fff5f9b921f37253ffca5131
FAIL: test_conflicts (test.easyconfigs.easyconfigs.EasyConfigTest)

Check whether any conflicts occur in software dependency graphs.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 297, in test_conflicts
    "No conflicts detected")
AssertionError: No conflicts detected

----------------------------------------------------------------------
Ran 13680 tests in 518.970s

FAILED (failures=1)
List of changed easyconfig files in this PR:
	tbb-2020.3-GCCcore-10.2.0.eb
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice you me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

]
dependencies = [
('Python', '3.8.6'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zarybnicky The easyconfigs test suite is failing, because adding Python 3.8.6 as a dependency causes trouble in easyconfigs that (indirectly) depend on tbb but also depend on Python 2.7.18...

To avoid this, we would have to add a versionsuffix to tbb, which also requires renaming the easyconfig file.

Instead, we could simply add an tbb-2020.3-GCCcore-10.2.0-Python-3.8.6.eb easyconfig, which would avoid that issue.

We'll still be in a bit of a pickle with epiScanpy that depends on the tbb Python bindings though...

Another option could be to install the tbb Python bindings as a separate module, and naming that tbb-python or something...
Would that be feasible?

@zarybnicky
Copy link
Contributor Author

I'll open another PR with TBB 2020.3 for foss/2021a, with TBB >2020.x left as another task for 2021b

@zarybnicky zarybnicky closed this Nov 26, 2021
@zarybnicky zarybnicky deleted the 20211125204822_new_pr_tbb20203 branch November 26, 2021 13:02
@zarybnicky
Copy link
Contributor Author

Continued in #14447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants