Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{cae}[foss/2020b] OpenFOAM vv2112 #15731

Merged
merged 4 commits into from
Jun 22, 2023
Merged

{cae}[foss/2020b] OpenFOAM vv2112 #15731

merged 4 commits into from
Jun 22, 2023

Conversation

DirectorSloan
Copy link
Contributor

(created using eb --new-pr)

akesandgren
akesandgren previously requested changes Jun 21, 2022
View reviewed changes
easybuild/easyconfigs/o/OpenFOAM/OpenFOAM-v2112-foss-2020b.eb Outdated
to solid dynamics and electromagnetics."""

toolchain = {'name': 'foss', 'version': '2020b'}
toolchainopts = {'cstd': 'c++11'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need 'vectorize': False for correctness.

See OpenFOAM-v2112-foss-2021b.eb

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this also applies when building OpenFOAM v2112 with foss/2020b, but it could.

See also #15495

Copy link
Contributor Author

@DirectorSloan DirectorSloan Jun 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I've take took over all requested changes and re-requested review.

How should I proceed? Besides my orignally bad easyconfig structure I can at least report from user experiences that without the patches OpenFOAMv2112 foss2020b is usable at our cluster. I'll will now rebuild in staging with the patches.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be usable without the patches, but they are vital to get OpenFOAM to use the dependencies from EasyBuild and to build paraFoam correctly.

easybuild/easyconfigs/o/OpenFOAM/OpenFOAM-v2112-foss-2020b.eb Outdated
Comment on lines 17 to 18
sources = [SOURCE_TGZ]
checksums = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing patches (see OpenFOAM-v2112-foss-2021b.eb)
patches = [
('OpenFOAM-v2012-cleanup.patch', 1),
'OpenFOAM-v1906-wmake-ompi.patch',
]

easybuild/easyconfigs/o/OpenFOAM/OpenFOAM-v2112-foss-2020b.eb Outdated
Comment on lines 33 to 38
builddependencies = [
('Bison', '3.7.1'),
('CMake', '3.18.4'),
('flex', '2.6.4'),
]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move before dependencies

easybuild/easyconfigs/o/OpenFOAM/OpenFOAM-v2112-foss-2020b.eb Outdated
Comment on lines 39 to 42
sanity_check_paths = {
'files': ['%(installdir)s/%(name)s-%(version)s/platforms/linux64GccDPInt32Opt/lib/dummy/libscotchDecomp.so'],
'dirs': ['%(installdir)s/%(name)s-%(version)s/platforms/linux64GccDPInt32Opt/lib/dummy'],
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove, the openfoam easyblock handles this part.

@boegel boegel added this to the 4.x milestone Jun 24, 2022
@boegel boegel added the update label Jun 24, 2022
@akesandgren
Copy link
Contributor

@boegelbot Please test @ generoso

@akesandgren
Copy link
Contributor

@boegelbot Please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@akesandgren: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=15731 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15731 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1350

Test results coming soon (I hope)...

- notification for comment with ID 1168246919 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 21 out of 22 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/66783f09e953fbaffe1a24c9b3df8509 for a full test report.

@boegel
Copy link
Member

boegel commented Jun 22, 2023

@boegelbot Please test @ jsc-zen2
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=15731 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_15731 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2853

Test results coming soon (I hope)...

- notification for comment with ID 1602842826 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2g1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/dabf8e448f3f393b1c684b09b460d253 for a full test report.

@boegel
Copy link
Member

boegel commented Jun 22, 2023

@boegelbot Please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15731 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_15731 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11089

Test results coming soon (I hope)...

- notification for comment with ID 1603017160 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx3 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/a3a2fef6d0bc6defedcae2aaa3d60368 for a full test report.

@boegel
Copy link
Member

boegel commented Jun 22, 2023

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (1 easyconfigs in total)
node3120.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/6392c4363c4527c781ed80e78b653779 for a full test report.

@boegel boegel dismissed akesandgren’s stale review June 22, 2023 21:42

missing patches added, other suggested changes also done

@boegel
Copy link
Member

boegel commented Jun 22, 2023

Going in, thanks @DirectorSloan!

@boegel boegel merged commit 830072f into easybuilders:develop Jun 22, 2023
5 checks passed
@boegel boegel modified the milestones: 4.x, next release (4.7.3?) Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

@akesandgren akesandgren Awaiting requested review from akesandgren

Assignees
No one assigned
Labels
update
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DirectorSloan @akesandgren @boegelbot @boegel