Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{cae}[foss/2020b] OpenFOAM vv2112 #15731

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions easybuild/easyconfigs/o/OpenFOAM/OpenFOAM-v2112-foss-2020b.eb
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
##
# Author: Robert Mijakovic <robert.mijakovic@lxp.lu>
##
name = 'OpenFOAM'
version = 'v2112'

homepage = 'https://www.openfoam.com/'
description = """OpenFOAM is a free, open source CFD software package.
OpenFOAM has an extensive range of features to solve anything from complex fluid flows
involving chemical reactions, turbulence and heat transfer,
to solid dynamics and electromagnetics."""

toolchain = {'name': 'foss', 'version': '2020b'}
toolchainopts = {'cstd': 'c++11'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need 'vectorize': False for correctness.

See OpenFOAM-v2112-foss-2021b.eb

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this also applies when building OpenFOAM v2112 with foss/2020b, but it could.

See also #15495

Copy link
Contributor Author

@DirectorSloan DirectorSloan Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I've take took over all requested changes and re-requested review.

How should I proceed? Besides my orignally bad easyconfig structure I can at least report from user experiences that without the patches OpenFOAMv2112 foss2020b is usable at our cluster. I'll will now rebuild in staging with the patches.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be usable without the patches, but they are vital to get OpenFOAM to use the dependencies from EasyBuild and to build paraFoam correctly.


source_urls = ['https://sourceforge.net/projects/openfoam/files/%(version)s/']
sources = [SOURCE_TGZ]
checksums = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing patches (see OpenFOAM-v2112-foss-2021b.eb)
patches = [
('OpenFOAM-v2012-cleanup.patch', 1),
'OpenFOAM-v1906-wmake-ompi.patch',
]

'3e838731e79db1c288acc27aad8cc8a43d9dac1f24e5773e3b9fa91419a8c3f7', # OpenFOAM-v2112.tgz
]

dependencies = [
('libreadline', '8.0'),
('ncurses', '6.2'),
# OpenFOAM requires 64 bit METIS using 32 bit indexes (array indexes)
('METIS', '5.1.0'),
('SCOTCH', '6.1.0'),
('CGAL', '5.2'),
('ParaView', '5.8.1', '-mpi'),
('gnuplot', '5.4.1'),
]

builddependencies = [
('Bison', '3.7.1'),
('CMake', '3.18.4'),
('flex', '2.6.4'),
]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move before dependencies

sanity_check_paths = {
'files': ['%(installdir)s/%(name)s-%(version)s/platforms/linux64GccDPInt32Opt/lib/dummy/libscotchDecomp.so'],
'dirs': ['%(installdir)s/%(name)s-%(version)s/platforms/linux64GccDPInt32Opt/lib/dummy'],
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove, the openfoam easyblock handles this part.


moduleclass = 'cae'