Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio}[GCC/11.2.0] Regenie v3.1.1, BGEN-enkre v1.1.7, Boost v1.55.0 #15752

Merged

Conversation

fizwit
Copy link
Contributor

@fizwit fizwit commented Jun 23, 2022

(created using eb --new-pr)

…-11.2.0.eb, Boost-1.55.0-GCC-11.2.0.eb and patches: regenie-3.1.1_Makefile.patch, 3rd-party-removal.patch, BGEN-enkre_streampos.patch
@boegelbot
Copy link
Collaborator

@fizwit: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/2549666245
Output from first failing test suite run:

FAIL: test_pr_sha256_checksums (test.easyconfigs.easyconfigs.EasyConfigTest)
Make sure changed easyconfigs have SHA256 checksums in place.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 916, in test_pr_sha256_checksums
    self.assertTrue(len(checksum_issues) == 0, "No checksum issues:\n%s" % '\n'.join(checksum_issues))
AssertionError: No checksum issues:
Checksums missing for one or more sources/patches in Regenie-3.1.1-GCC-11.2.0.eb: found 1 sources + 1 patches vs 0 checksums

----------------------------------------------------------------------
Ran 14936 tests in 556.197s

FAILED (failures=1)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice you me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@verdurin
Copy link
Member

Ping @fizwit

@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
centos7.lan - Linux CentOS Linux 7.9.2009, x86_64, Intel Core Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/07440ab1141b3ff57e98626e0787e63f for a full test report.

@fizwit
Copy link
Contributor Author

fizwit commented Sep 28, 2022

You pinged me?

@verdurin
Copy link
Member

Test report by @verdurin
FAILED
Build succeeded for 1 out of 3 (3 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/ddb8098acf1033f348aa4c4a0c20d82a for a full test report.

@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
centos7.lan - Linux CentOS Linux 7.9.2009, x86_64, Intel Core Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/eebc193b00796e7cf400bdb218446d6d for a full test report.

@verdurin
Copy link
Member

@fizwit yes, I think they have regenerated the tarball in some way, so the checksum has changed (date is now 2022-09-10). Could you check, please?

Neves-P added a commit to rug-cit-hpc/cit-hpc-easybuild that referenced this pull request Jan 26, 2024
@fizwit
Copy link
Contributor Author

fizwit commented Jun 21, 2024

The checksum has not changed. What checksum do you have? I'll add it to the list.

@verdurin
Copy link
Member

verdurin commented Jul 4, 2024

Test report by @verdurin
FAILED
Build succeeded for 1 out of 3 (3 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/4c04c68bbcc8a17daea23f0936539be5 for a full test report.

@verdurin
Copy link
Member

verdurin commented Jul 4, 2024

@fizwit here's what I see:

== 2024-07-04 08:18:04,437 filetools.py:1307 DEBUG Computed sha256 checksum for /eb/maint/sources/b/BGEN-enkre/1.1.7.tgz: b922ac22c1c0e365d0de6054f6ce2ad911bc81db5bcd8ca915bae750f57bd0a7 (correct checksum: 8173d614ae629f00c84c0e6edd7d16f56a61af2e5a8717e8fe0167f530a6aabb)
== 2024-07-04 08:18:04,439 build_log.py:171 ERROR EasyBuild crashed with an error (at easybuild/base/exceptions.py:126 in __init__): Checksum verification for /eb/maint/sources/b/BGEN-enkre/1.1.7.tgz using 8173d614ae629f00c84c0e6edd7d16f56a61af2e5a8717e8fe0167f530a6aabb failed. (at easybuild/framework/easyblock.py:2468 in checksum_step)

@verdurin
Copy link
Member

verdurin commented Jul 4, 2024

That's the checksum I see when I download it on my laptop, too i.e.
b922ac22c1c0e365d0de6054f6ce2ad911bc81db5bcd8ca915bae750f57bd0a7

@fizwit
Copy link
Contributor Author

fizwit commented Jul 11, 2024

This has happened to me before. The EU version is different from North America's. I am not able to reproduce the checksum that you see. Interestingly, there are four different tarballs of 1.1.7 to choose from.

https://code.enkre.net/bgen/tarball/release/
6476b077af6c8e98e85fd7e09f58cb3fdf143ff91850c984248fd4dc2d74a8c3  v1.1.7.tar.gz
6476b077af6c8e98e85fd7e09f58cb3fdf143ff91850c984248fd4dc2d74a8c3  v1.1.7.tgz
dc1ba4c94bc634a6ac77690031c11f947a052c633dee3914fc61d063437faac2  1.1.7.tar.gz
8173d614ae629f00c84c0e6edd7d16f56a61af2e5a8717e8fe0167f530a6aabb  1.1.7.tgz

https://code.enkre.net/bgen/tarball/
708526b1ca897a679ca13d160eea014c5d2197f3f1715795ed4cab46e919dae8  v1.1.7.tgz
bda0bb8a13020c39b78f91d751c2e5ed31ee932244a56588ac5a663122a0acf4  1.1.7.tgz

@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 23 out of 23 (3 easyconfigs in total)
easybuild-el8.cloud.in.bmrc.ox.ac.uk - Linux Rocky Linux 8.10, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/eb1501049b4129498ac0558f69130099 for a full test report.

@fizwit
Copy link
Contributor Author

fizwit commented Jul 15, 2024

@verdurin, @Micket has requested that we compare downloads. It would be nice if there was a shared location where we could compare source downloads.

@Micket
Copy link
Contributor

Micket commented Jul 15, 2024

As far as i know, you are the only person who managed to download all the different versions, everyone else is getting
8173d614ae629f00c84c0e6edd7d16f56a61af2e5a8717e8fe0167f530a6aabb 1.1.7.tgz
so, you can just unpack the ones you have and diff? I simply suspect that it's either

  1. partial download and only the last version works at all, so the checksum is doing its job
  2. autogenerated tarball with updated timestamps, which makes checksums unreliable at all.

@fizwit
Copy link
Contributor Author

fizwit commented Jul 16, 2024

The difference is the name of the top directory.

diff --brief 1_1_7_tar_gz/1.1.7 1_1_7_tgz/1.1.7.tgz/

@Micket
Copy link
Contributor

Micket commented Jul 16, 2024

their webpage autogenerates whatever filename you specify
http://code.enkre.net/bgen/tarball/release/foobar.tgz
will have foobar.tgz with the dir foobar/ inside
At least nowdays.

These downloads are highly misleading, as they it's the "release" part that actually determines the version, the bit at the end is useless.

I would prefer git checkout instead of this unreliable tarball. At the very lease, we must use

sources = ['http://code.enkre.net/bgen/tarball/v%(version)s/']

@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
easybuild-el8.cloud.in.bmrc.ox.ac.uk - Linux Rocky Linux 8.10, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/01fd2e9cc8a9cc80d83aa5d016a7fecb for a full test report.

@verdurin
Copy link
Member

@Micket looks okay to me now - happy for it to be merged?

@verdurin
Copy link
Member

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=15752 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_15752 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14051

Test results coming soon (I hope)...

- notification for comment with ID 2285666351 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/309a444c6d0aa2ac0203dce53e875d4b for a full test report.

@verdurin
Copy link
Member

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=15752 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_15752 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4684

Test results coming soon (I hope)...

- notification for comment with ID 2289061321 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/33475a2b82ec2446894d44bfecb0e16e for a full test report.

@verdurin verdurin added this to the release after 4.9.2 milestone Aug 14, 2024
Copy link
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Member

Going in, thanks @fizwit!

1 similar comment
@verdurin
Copy link
Member

Going in, thanks @fizwit!

@verdurin verdurin merged commit 97d027e into easybuilders:develop Aug 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants