Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{data}[iimpi/2022a] netCDF-Fortran v4.6.0, netCDF v4.9.0 #16009

Conversation

SimonPinches
Copy link
Contributor

(created using eb --new-pr)

@SebastianAchilles SebastianAchilles added this to the 4.x milestone Aug 9, 2022
@SebastianAchilles
Copy link
Member

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=16009 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16009 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1435

Test results coming soon (I hope)...

- notification for comment with ID 1209378772 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/150163795b0f2a6802655df10d2e0838 for a full test report.

@SimonPinches SimonPinches force-pushed the 20220809143954_new_pr_netCDF-Fortran460 branch from 431f3ee to 06990d3 Compare August 9, 2022 16:21
@SebastianAchilles
Copy link
Member

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=16009 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16009 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8974

Test results coming soon (I hope)...

- notification for comment with ID 1209676137 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/c1faf4988b8a2c8606feb6170eb51871 for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
zen2-ubuntu-eb - Linux Ubuntu 22.04, x86_64, AMD EPYC 7452 32-Core Processor (zen2), Python 3.10.4
See https://gist.github.com/36aa99ff1e3f59dff967d9174d16b501 for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bdw-opensuse-154 - Linux openSUSE Leap 15.4, x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), 2 x NVIDIA NVIDIA GeForce GTX 1060 6GB, 510.85.02, Python 3.6.15
See https://gist.github.com/d496983741572cd3e9a51d535b4d8a9c for a full test report.

@Micket
Copy link
Contributor

Micket commented Aug 11, 2022

Test report by @boegelbot FAILED Build succeeded for 0 out of 2 (2 easyconfigs in total) cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8 See https://gist.github.com/c1faf4988b8a2c8606feb6170eb51871 for a full test report.

@branfosj noted that this failure is likely the same issue as #15959
If so, then it's almost certainly the NASA benchmark test that times out. It's a test that does parallell IO, so, perhaps it's related to filesystem? Could be horrendously slow on some systems? It takes 168s on my machine, so as far as i could tell, it would need to be running waaay slower to hit the time limit in ctest.
Does generoso bot build on /dev/shm? I never got access there

@Micket
Copy link
Contributor

Micket commented Aug 17, 2022

See patch in #16050

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the netCDF-%(version)s_skip-nasa-test.patch patch that was just merged.

@Micket
Copy link
Contributor

Micket commented Aug 18, 2022

uhm, i don't think you should have merged the commit (since that commit is already merged into develop). This needs to be rebased on develop anyway now

@SimonPinches
Copy link
Contributor Author

@Micket, yeah, I think I got a bit carried away there. I'll reset to before the merge and then rebase onto develop.

@SimonPinches SimonPinches force-pushed the 20220809143954_new_pr_netCDF-Fortran460 branch from 71958e3 to 1acfc6c Compare August 18, 2022 17:23
Micket
Micket previously approved these changes Aug 19, 2022
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Aug 19, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=16009 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16009 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9030

Test results coming soon (I hope)...

- notification for comment with ID 1220830313 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Micket
Copy link
Contributor

Micket commented Aug 19, 2022

Test report by @Micket
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.5, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/d0db527260df8e0c286abc64d0dc5475 for a full test report.

@Micket
Copy link
Contributor

Micket commented Aug 19, 2022

ugh

206/227 Test #206: dap4_test_test_thredds ................***Failed  129.72 sec
unknown argument test_thredds.sh
test_thredds.sh:
testing: dap4://thredds-test.unidata.ucar.edu/thredds/dap4/casestudies/harvey/goes16/CONUS/Channel01/20170821/GOES16_CONUS_20170821_020218_0.47_1km_33.3N_91.4W.nc4?dap4.ce=y#checksummode=ignore
Error:curl error: Timeout was reached
/dev/shm/netCDF/4.9.0/iimpi-2022a/easybuild_obj/ncdump/ncdump: dap4://thredds-test.unidata.ucar.edu/thredds/dap4/casestudies/harvey/goes16/CONUS/Channel01/20170821/GOES16_CONUS_20170821_020218_0.47_1km_33.3N_91.4W.nc4?dap4.ce=y#checksummode=ignore: NetCDF: libcurl failure
*** Fail: dap4://thredds-test.unidata.ucar.edu/thredds/dap4/casestudies/harvey/goes16/CONUS/Channel01/20170821/GOES16_CONUS_20170821_020218_0.47_1km_33.3N_91.4W.nc4?dap4.ce=y#checksummode=ignore

tests are trying to fetch things online, and it seems this was down now when i tried to build it.

We can consider skipping these tests, if it's just dap4_ stuff that's affected here

runtest = 'test ARGS="-E dap4"'

(of course, do the same for the gompi version)

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/6e763ca5be2758bca9f9fe4c2f36453c for a full test report.

@Micket Micket closed this Aug 29, 2022
@Micket Micket reopened this Aug 29, 2022
@Micket
Copy link
Contributor

Micket commented Aug 29, 2022

Bah, sorry about that, i stumbled over the keyboard and accidentally closed

Disable DAP remote tests

Co-authored-by: Mikael Öhman <micketeer@gmail.com>
@Micket
Copy link
Contributor

Micket commented Aug 30, 2022

Sorry i was unclear, you don't need the -E dap4 thing thanks to the cmake configuration line that disables the exact tests instead.

I'm just holding off merging this because a big issue was discovered with HDF5, and we'll need to downgrade to 1.12.2
See #16153

@SimonPinches
Copy link
Contributor Author

@Micket, Ah, okay. I'll remove this last commit then.

@SimonPinches SimonPinches force-pushed the 20220809143954_new_pr_netCDF-Fortran460 branch from daa1824 to 5611a5e Compare August 30, 2022 13:59
Micket
Micket previously requested changes Sep 1, 2022
easybuild/easyconfigs/n/netCDF/netCDF-4.9.0-iimpi-2022a.eb Outdated Show resolved Hide resolved
Co-authored-by: Mikael Öhman <micketeer@gmail.com>
@SebastianAchilles
Copy link
Member

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=16009 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16009 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9578

Test results coming soon (I hope)...

- notification for comment with ID 1319745436 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
zen2-ubuntu-2204 - Linux Ubuntu 22.04.1 LTS (Jammy Jellyfish), x86_64, AMD EPYC 7452 32-Core Processor (zen2), Python 3.10.6
See https://gist.github.com/8063812a14458d635284618526b39ee4 for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bwd-rockylinux-90 - Linux Rocky Linux 9.0 (Blue Onyx), x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), Python 3.9.10
See https://gist.github.com/4b022287009c54c17c4fd7507b04fe6b for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
skl-opensuse-154 - Linux openSUSE Leap 15.4, x86_64, Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (skylake), Python 3.6.15
See https://gist.github.com/77417158b43ede130c2b5874583b3c6d for a full test report.

@SebastianAchilles
Copy link
Member

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=16009 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_16009 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1794

Test results coming soon (I hope)...

- notification for comment with ID 1319760227 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/fa2e009287de46063190b72f715accc0 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/5268e453fbe25525638b16c38b1d6964 for a full test report.

Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles SebastianAchilles dismissed Micket’s stale review November 18, 2022 11:45

Requested changes were applied

@SebastianAchilles
Copy link
Member

Going in, thanks @SimonPinches!

@SebastianAchilles SebastianAchilles merged commit 931b4b9 into easybuilders:develop Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants