-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{data}[iimpi/2022a] netCDF-Fortran v4.6.0, netCDF v4.9.0 #16009
{data}[iimpi/2022a] netCDF-Fortran v4.6.0, netCDF v4.9.0 #16009
Conversation
@boegelbot please test @ jsc-zen2 |
@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1209378772 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
431f3ee
to
06990d3
Compare
@boegelbot please test @ generoso |
@SebastianAchilles: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1209676137 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @SebastianAchilles |
Test report by @SebastianAchilles |
@branfosj noted that this failure is likely the same issue as #15959 |
See patch in #16050 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add the netCDF-%(version)s_skip-nasa-test.patch patch that was just merged.
uhm, i don't think you should have merged the commit (since that commit is already merged into develop). This needs to be rebased on develop anyway now |
@Micket, yeah, I think I got a bit carried away there. I'll reset to before the merge and then rebase onto develop. |
71958e3
to
1acfc6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@boegelbot please test @ generoso |
@Micket: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1220830313 processed Message to humans: this is just bookkeeping information for me, |
Test report by @Micket |
ugh
tests are trying to fetch things online, and it seems this was down now when i tried to build it. We can consider skipping these tests, if it's just dap4_ stuff that's affected here runtest = 'test ARGS="-E dap4"' (of course, do the same for the gompi version) |
Test report by @boegelbot |
Bah, sorry about that, i stumbled over the keyboard and accidentally closed |
Disable DAP remote tests Co-authored-by: Mikael Öhman <micketeer@gmail.com>
Sorry i was unclear, you don't need the -E dap4 thing thanks to the cmake configuration line that disables the exact tests instead. I'm just holding off merging this because a big issue was discovered with HDF5, and we'll need to downgrade to 1.12.2 |
@Micket, Ah, okay. I'll remove this last commit then. |
daa1824
to
5611a5e
Compare
Co-authored-by: Mikael Öhman <micketeer@gmail.com>
@boegelbot please test @ generoso |
@SebastianAchilles: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1319745436 processed Message to humans: this is just bookkeeping information for me, |
Test report by @SebastianAchilles |
Test report by @SebastianAchilles |
Test report by @SebastianAchilles |
@boegelbot please test @ jsc-zen2 |
@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1319760227 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…asyconfigs into 20220809143954_new_pr_netCDF-Fortran460
Requested changes were applied
Going in, thanks @SimonPinches! |
(created using
eb --new-pr
)