Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{data}[GCCcore/11.3.0] SoX w/ GCCcore/11.3.0 + additional format support #16055

Merged
merged 4 commits into from
Aug 19, 2022
Merged

{data}[GCCcore/11.3.0] SoX w/ GCCcore/11.3.0 + additional format support #16055

merged 4 commits into from
Aug 19, 2022

Conversation

anselmicz
Copy link
Contributor

@anselmicz anselmicz commented Aug 17, 2022

Hi.
Since the existing SoX is built on GCC/8.3.0, I decided to upgrade it and add support for other sound file types after receiving a request for SoX some time ago.

Edit:
To be absolutely clear, here are the changes in supported file formats

 OPTIONAL FILE FORMATS
 amrnb......................no
 amrwb......................no
-flac.......................no
+flac.......................yes
 gsm........................yes (in-tree)
 lpc10......................yes (in-tree)
-mp2/mp3....................no
+mp2/mp3....................yes
  id3tag....................no
- lame......................no
+ lame......................yes
+ lame id3tag...............yes
+ dlopen lame...............no
  mad.......................no
  twolame...................no
-oggvorbis..................no
+oggvorbis..................yes
 opus.......................no
 sndfile....................no
 wavpack....................no

@Micket Micket added the update label Aug 18, 2022
@Micket Micket added this to the next release (4.6.1?) milestone Aug 18, 2022
@anselmicz anselmicz requested a review from Micket August 19, 2022 07:33
….0.eb

Switched from GCC to GCCcore, added binutils to builddependencies
@anselmicz anselmicz requested review from bedroge and removed request for Micket August 19, 2022 08:34
Adding simple sanity check.

Co-authored-by: Bob Dröge <b.e.droge@rug.nl>
@anselmicz anselmicz changed the title {data}[GCC/11.3.0] SoX w/ GCC/11.3.0 + additional format support {data}[GCCcore/11.3.0] SoX w/ GCCcore/11.3.0 + additional format support Aug 19, 2022
@Micket
Copy link
Contributor

Micket commented Aug 19, 2022

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.5, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/6810e4eeb648ddcf7bc34cd78611ecc9 for a full test report.

@bedroge
Copy link
Contributor

bedroge commented Aug 19, 2022

Test report by @bedroge
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bob-Latitude-5300 - Linux Ubuntu 22.04, x86_64, Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz, Python 3.10.4
See https://gist.github.com/2a9f4017f51ae9399dabc81eb9292082 for a full test report.

@bedroge
Copy link
Contributor

bedroge commented Aug 19, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@bedroge: Request for testing this PR well received on login1

PR test command 'EB_PR=16055 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16055 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9029

Test results coming soon (I hope)...

- notification for comment with ID 1220460861 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/3d696e403600db3b74cbc39e502c9d71 for a full test report.

@bedroge
Copy link
Contributor

bedroge commented Aug 19, 2022

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@bedroge: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=16055 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16055 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1470

Test results coming soon (I hope)...

- notification for comment with ID 1220468894 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/9c0f156276ef9098e64377e7ce430efb for a full test report.

Use `SOURCEFORGE_SOURCE` instead of full url

Co-authored-by: Bob Dröge <b.e.droge@rug.nl>
@anselmicz anselmicz requested a review from bedroge August 19, 2022 10:30
@bedroge
Copy link
Contributor

bedroge commented Aug 19, 2022

Test report by @bedroge
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bob-Latitude-5300 - Linux Ubuntu 22.04, x86_64, Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz, Python 3.10.4
See https://gist.github.com/47ff20d6672811a09265e9e642add640 for a full test report.

Copy link
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bedroge
Copy link
Contributor

bedroge commented Aug 19, 2022

Going in, thanks @anselmicz!

@bedroge bedroge merged commit fb312a5 into easybuilders:develop Aug 19, 2022
@anselmicz anselmicz deleted the SoX-14.4.2-GCC-11.3.0 branch August 19, 2022 12:18
('FLAC', '1.3.4'),
('LAME', '3.100'),
('libvorbis', '1.3.7'),
('FFmpeg', '5.0.1'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been FFmpeg 4.4.2, to ensure compatibility with easyconfigs using foss/2022a toolchain that already depend on FFmpeg 4.4.2.

Fixed in #17998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants