Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile fix for the testthat 2.1.1 extension in R 3.6.0 #17175

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

crubb
Copy link
Contributor

@crubb crubb commented Jan 21, 2023

(created using eb --new-pr)

Fix for
../inst/include/testthat/vendor/catch.h:6495:33: error: size of array ‘altStackMem’ is not an integral constant-expression

See

@boegel boegel added the bug fix label Sep 20, 2023
@boegel boegel added this to the next release (4.8.2?) milestone Sep 20, 2023
@boegel
Copy link
Member

boegel commented Sep 20, 2023

This probably also fixes these errors that occur with testthat 3.0.2 in R-4.1.0-foss-2021a.eb:

../inst/include/testthat/vendor/catch.h:6495:41: error: array bound is not an integer constant before ] token
 6495 |         static char altStackMem[SIGSTKSZ];
      |                                         ^
../inst/include/testthat/vendor/catch.h: In constructor Catch::FatalConditionHandler::FatalConditionHandler():
../inst/include/testthat/vendor/catch.h:6514:30: error: altStackMem was not declared in this scope
 6514 |             sigStack.ss_sp = altStackMem;
      |                              ^~~~~~~~~~~
../inst/include/testthat/vendor/catch.h: At global scope:
../inst/include/testthat/vendor/catch.h:6546:53: error: array bound is not an integer constant before ] token
 6546 |

So we should try and apply the same patch to testthat in more recent R easyconfigs as well.

The fix is included in testthat v3.1.0, cfr. r-lib/testthat@c784176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants