Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{vis}[foss/2023a] napari v0.4.19.post1, VisPy v0.14.1 w/ Python v3.11.3 #19664

Conversation

ThomasHoffmann77
Copy link
Contributor

@ThomasHoffmann77 ThomasHoffmann77 commented Jan 22, 2024

(created using eb --new-pr)

@ThomasHoffmann77 ThomasHoffmann77 changed the title {vis}[foss/2023a] napari v4.19rc3, Qtconsole v5.5.1, VisPy v0.14.1, pydantic v2.5.3 w/ Python v3.11.3 {vis}[foss/2023a] napari v4.19rc3, Qtconsole v5.5.1, VisPy v0.14.1, PyOpenGL v3.1.7, QtPy v2.4.1, w/ Python v3.11.3 Jan 22, 2024
@jfgrimm
Copy link
Member

jfgrimm commented Jan 22, 2024

see also: #19652
Assuming you're also working on RELION 5, I have more PRs coming

@ThomasHoffmann77
Copy link
Contributor Author

see also: #19652 Assuming you're also working on RELION 5, I have more PRs coming

see #19240 - did not port it to 2023a, yet. looking forward to your PRs.

regarding napari 0.4.18 vs 0.4.19rc3. The pydantic < 2 requirement might lead to conflicts. 4.19 uses pydantic_compat.

@jfgrimm
Copy link
Member

jfgrimm commented Jan 22, 2024

see also: #19652 Assuming you're also working on RELION 5, I have more PRs coming

see #19240 - did not port it to 2023a, yet. looking forward to your PRs.

regarding napari 0.4.18 vs 0.4.19rc3. The pydantic < 2 requirement might lead to conflicts. 4.19 uses pydantic_compat.

made a draft here: #19678

@ThomasHoffmann77 ThomasHoffmann77 changed the title {vis}[foss/2023a] napari v4.19rc3, Qtconsole v5.5.1, VisPy v0.14.1, PyOpenGL v3.1.7, QtPy v2.4.1, w/ Python v3.11.3 {vis}[foss/2023a] napari v0.4.19, Qtconsole v5.5.1, VisPy v0.14.1, PyOpenGL v3.1.7, QtPy v2.4.1, w/ Python v3.11.3 Feb 1, 2024
add checksum for pydantic_compat
update napari-plugin-engine2 to version 0.7.4
adjust dependency imageio to ver 2.33.1
@jfgrimm
Copy link
Member

jfgrimm commented Feb 29, 2024

@ThomasHoffmann77 can you fix the conflicts please?

@ThomasHoffmann77 ThomasHoffmann77 changed the title {vis}[foss/2023a] napari v0.4.19, Qtconsole v5.5.1, VisPy v0.14.1, PyOpenGL v3.1.7, QtPy v2.4.1, w/ Python v3.11.3 {vis}[foss/2023a] napari v0.4.19.post1, VisPy v0.14.1 w/ Python v3.11.3 Mar 1, 2024
@ThomasHoffmann77
Copy link
Contributor Author

@ThomasHoffmann77 can you fix the conflicts please?
@jfgrimm I deleted PyOpenGL, Qtconsole, and QtPy. I updated some extensions and to 0.4.19.post1.
I opened a new PR #20007 to add PyOpenGL-accelerate.

@ThomasHoffmann77
Copy link
Contributor Author

@jfgrimm I downgraded the VisPy dependency from 0.14.1 to 0.12.2 since there was a conflict with the napari 0.4.18 easyconfig. Preferably I'd like to keep the newer version of VisPy.

@ThomasHoffmann77
Copy link
Contributor Author

Test report by @ThomasHoffmann77
FAILED
Build succeeded for 1 out of 3 (6 easyconfigs in total)
srv-mahamid-01.embl.de - Linux AlmaLinux 8.8, x86_64, AMD EPYC 7513 32-Core Processor, 2 x NVIDIA NVIDIA GeForce RTX 3090, 535.113.01, Python 3.6.8
See https://gist.github.com/ThomasHoffmann77/dfcccd87696ced64a8cad347055edad6 for a full test report.

@ThomasHoffmann77
Copy link
Contributor Author

Test report by @ThomasHoffmann77
FAILED
Build succeeded for 0 out of 2 (6 easyconfigs in total)
srv-mahamid-01.embl.de - Linux AlmaLinux 8.8, x86_64, AMD EPYC 7513 32-Core Processor, 2 x NVIDIA NVIDIA GeForce RTX 3090, 535.113.01, Python 3.6.8
See https://gist.github.com/ThomasHoffmann77/9f8d87068c021bbbee47eeb18df266e0 for a full test report.

@ThomasHoffmann77
Copy link
Contributor Author

Test report by @ThomasHoffmann77
FAILED
Build succeeded for 0 out of 2 (7 easyconfigs in total)
srv-mahamid-01.embl.de - Linux AlmaLinux 8.8, x86_64, AMD EPYC 7513 32-Core Processor, 2 x NVIDIA NVIDIA GeForce RTX 3090, 535.113.01, Python 3.6.8
See https://gist.github.com/ThomasHoffmann77/1ef026d81ffb48d4265e348c2321a22a for a full test report.

@ThomasHoffmann77
Copy link
Contributor Author

Test report by @ThomasHoffmann77
FAILED
Build succeeded for 2 out of 3 (7 easyconfigs in total)
srv-mahamid-01.embl.de - Linux AlmaLinux 8.8, x86_64, AMD EPYC 7513 32-Core Processor, 2 x NVIDIA NVIDIA GeForce RTX 3090, 535.113.01, Python 3.6.8
See https://gist.github.com/ThomasHoffmann77/0885fe8e76a35d337f40b0230390a594 for a full test report.

@ThomasHoffmann77
Copy link
Contributor Author

Test report by @ThomasHoffmann77
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
srv-mahamid-01.embl.de - Linux AlmaLinux 8.8, x86_64, AMD EPYC 7513 32-Core Processor, 2 x NVIDIA NVIDIA GeForce RTX 3090, 535.113.01, Python 3.6.8
See https://gist.github.com/ThomasHoffmann77/b0a2112a1f875e261fc111fdcf7465a7 for a full test report.

Copy link
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for not looking at this again sooner

easybuild/easyconfigs/v/VisPy/VisPy-0.14.1-foss-2023a.eb Outdated Show resolved Hide resolved
@jfgrimm
Copy link
Member

jfgrimm commented May 16, 2024

Test report by @jfgrimm
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node086.viking2.yor.alces.network - Linux Rocky Linux 8.9, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/5e5fc117102596c1ce98dd8b4db9cc7a for a full test report.

Co-authored-by: Jasper Grimm <65227842+jfgrimm@users.noreply.github.com>
@jfgrimm
Copy link
Member

jfgrimm commented May 16, 2024

@boegelbot: please test @ generoso

@jfgrimm jfgrimm added this to the release after 4.9.1 milestone May 16, 2024
@boegelbot
Copy link
Collaborator

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=19664 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19664 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13476

Test results coming soon (I hope)...

- notification for comment with ID 2115485749 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@jfgrimm
Copy link
Member

jfgrimm commented May 16, 2024

Test report by @jfgrimm
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node086.viking2.yor.alces.network - Linux Rocky Linux 8.9, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/6935c9f6f279db28017d86eccdee10ce for a full test report.

@jfgrimm jfgrimm added the update label May 16, 2024
jfgrimm
jfgrimm previously approved these changes May 16, 2024
Copy link
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just waiting on the bot reports + CI)

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/63ff5316550ee8de14cd6a506a8a238a for a full test report.

@jfgrimm
Copy link
Member

jfgrimm commented May 16, 2024

jsc-zen3 build failed with:

asyncpg 0.29.0 has requirement async-timeout>=4.0.3; python_version < "3.12.0", but you have async-timeout 4.0.2.

@jfgrimm
Copy link
Member

jfgrimm commented May 17, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=19664 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19664 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13484

Test results coming soon (I hope)...

- notification for comment with ID 2117145510 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/0d2eb8172fea56eac14fef4f0b308065 for a full test report.

@jfgrimm
Copy link
Member

jfgrimm commented May 17, 2024

I've traced the difference between my installations and the bots to the following PR: #20511

@jfgrimm
Copy link
Member

jfgrimm commented May 17, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=19664 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19664 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13493

Test results coming soon (I hope)...

- notification for comment with ID 2117669847 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/fc234641e4e50576d2410325037742df for a full test report.

@jfgrimm
Copy link
Member

jfgrimm commented May 17, 2024

@boegelbot: please test @ jsc-zen3

@ThomasHoffmann77
Copy link
Contributor Author

@jfgrimm are the sanity pip check messages about missing hatchling related to 20546 and jupyter-server?

@boegelbot
Copy link
Collaborator

@jfgrimm: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=19664 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_19664 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4150

Test results coming soon (I hope)...

- notification for comment with ID 2117694597 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/5ae390c56fde5d9056cfc5999c9fe908 for a full test report.

Copy link
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

will merge once #20553 is merged

@jfgrimm
Copy link
Member

jfgrimm commented May 20, 2024

Going in, thanks @ThomasHoffmann77!

@jfgrimm jfgrimm merged commit e142610 into easybuilders:develop May 20, 2024
9 checks passed
@easybuilders easybuilders deleted a comment from boegelbot Jun 10, 2024
@easybuilders easybuilders deleted a comment from boegelbot Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants