Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JupyterHub v4.0.2: replace SQLAlchemy extension with regular dependency #20511

Merged

Conversation

lexming
Copy link
Contributor

@lexming lexming commented May 10, 2024

(created using eb --new-pr)

@lexming lexming changed the title replace SQLAlchemy extension with regular dependency in JupyterHub v4.0.2 JupyterHub v4.0.2: replace SQLAlchemy extension with regular dependency May 10, 2024
@lexming lexming added the change label May 10, 2024
@lexming
Copy link
Contributor Author

lexming commented May 10, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=20511 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20511 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13446

Test results coming soon (I hope)...

- notification for comment with ID 2105348563 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/98047425070e2e53a6bd60bb2cd7dcd2 for a full test report.

@lexming
Copy link
Contributor Author

lexming commented May 10, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20511 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20511 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4104

Test results coming soon (I hope)...

- notification for comment with ID 2105354852 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/d1dcf326bd4dd8bcddbe19a8de9d7bdc for a full test report.

@verdurin
Copy link
Member

@lexming is this just for consistency? Or is it fixing any bugs?

@lexming
Copy link
Contributor Author

lexming commented May 13, 2024

@verdurin just consistency and a bit of efficiency avoiding duplicate installations of the same software

@smoors smoors added this to the release after 4.9.1 milestone May 13, 2024
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented May 13, 2024

Going in, thanks @lexming!

@smoors smoors merged commit f6a4482 into easybuilders:develop May 13, 2024
9 checks passed
@lexming lexming deleted the 20240510171151_new_pr_JupyterHub402 branch May 13, 2024 13:07
@jfgrimm
Copy link
Member

jfgrimm commented May 17, 2024

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node017.viking2.yor.alces.network - Linux Rocky Linux 8.9, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/72f4247fe370b8c8e22dcf628cf159d1 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants