-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JupyterHub v4.0.2: replace SQLAlchemy extension with regular dependency #20511
JupyterHub v4.0.2: replace SQLAlchemy extension with regular dependency #20511
Conversation
@boegelbot: please test @ generoso |
@lexming: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2105348563 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ jsc-zen3 |
@lexming: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2105354852 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@lexming is this just for consistency? Or is it fixing any bugs? |
@verdurin just consistency and a bit of efficiency avoiding duplicate installations of the same software |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @lexming! |
Test report by @jfgrimm |
(created using
eb --new-pr
)