Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change arrow-R dependency of Bioconductor v3.18 to v14.0.1 (which depends on required matching Arrow v14.0.1) #20324

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

bedroge
Copy link
Contributor

@bedroge bedroge commented Apr 9, 2024

Bioconductor had a dependency on arrow-R 14.0.0.2, which depends on Arrow 14.0.1. However, those versions are not compatible, as the build log shows:

**** Not using: C++ library version (14.0.1) does not match R package (14.0.0.2)

It will then try to build its own version of Arrow. The script used by the build to check this has the following comment:

    # Patch releases we do for CRAN feedback get an extra x.y.z.1 version.
    # These should work with the x.y.z C++ library (which never has .1 added)

There are no CRAN source tarballs for arrow-R 14.0.1.x though (see https://cran.r-project.org/src/contrib/Archive/arrow/), so I fixed it for this version by taking the full Arrow source tarball for version 14.0.1, which contains everything (C++/R/Python sources).

I also modified Bioconductor, so that it now uses this version of arrow-R. I couldn't find any other packages that depend on arrow-R.

@bedroge
Copy link
Contributor Author

bedroge commented Apr 9, 2024

I've also added the same comment about compatible Arrow versions to some older arrow-R easyconfigs to prevent this from happening again. I'm just not sure what to do with arrow-R-14.0.0.2-foss-2023a-R-4.3.2.eb, as it violates this and is somewhat broken (it will build its own Arrow).

@verdurin
Copy link
Member

verdurin commented Apr 9, 2024

Test report by @verdurin
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/b844665e7a17baec2b9a1c9b826aaca9 for a full test report.

@verdurin
Copy link
Member

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=20324 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20324 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13269

Test results coming soon (I hope)...

- notification for comment with ID 2046856085 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/e4319652ed2d5dbef4e90f76f098d6ee for a full test report.

@verdurin
Copy link
Member

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20324 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20324 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3943

Test results coming soon (I hope)...

- notification for comment with ID 2051910572 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/fcabe1163ec9e7e7112eb8a6b4bc10d5 for a full test report.

@boegel boegel added this to the release after 4.9.1 milestone Apr 16, 2024
@boegel boegel added change and removed update labels Apr 16, 2024
@boegel boegel changed the title fix the arrow-R dependency of Bioconductor 3.18 and let it match the Arrow version change arrow-R dependency of Bioconductor v3.18 to v14.0.1 (which depends on required matching Arrow v14.0.1) Apr 16, 2024
@boegel
Copy link
Member

boegel commented Apr 16, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20324 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20324 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3984

Test results coming soon (I hope)...

- notification for comment with ID 2059459740 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/70542aba1a576fd0fe45edc4ca5e4712 for a full test report.

@boegel
Copy link
Member

boegel commented Apr 16, 2024

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3113.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/d5da50c58811df5c5bc99869ce509113 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 10a6454 into easybuilders:develop Apr 17, 2024
9 checks passed
@bedroge bedroge deleted the fix_bioconductor_arrow-r branch April 17, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix change EESSI Related to EESSI project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants