-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change arrow-R dependency of Bioconductor v3.18 to v14.0.1 (which depends on required matching Arrow v14.0.1) #20324
change arrow-R dependency of Bioconductor v3.18 to v14.0.1 (which depends on required matching Arrow v14.0.1) #20324
Conversation
…ile the existing 14.0.0.2 is not)
I've also added the same comment about compatible Arrow versions to some older arrow-R easyconfigs to prevent this from happening again. I'm just not sure what to do with |
Test report by @verdurin |
@boegelbot please test @ generoso |
@verdurin: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2046856085 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ jsc-zen3 |
@verdurin: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2051910572 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ jsc-zen3 |
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2059459740 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @boegel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Bioconductor had a dependency on arrow-R 14.0.0.2, which depends on Arrow 14.0.1. However, those versions are not compatible, as the build log shows:
It will then try to build its own version of Arrow. The script used by the build to check this has the following comment:
There are no CRAN source tarballs for arrow-R 14.0.1.x though (see https://cran.r-project.org/src/contrib/Archive/arrow/), so I fixed it for this version by taking the full Arrow source tarball for version 14.0.1, which contains everything (C++/R/Python sources).
I also modified Bioconductor, so that it now uses this version of arrow-R. I couldn't find any other packages that depend on arrow-R.