Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NCL deps ESMF and UDUNITS, and their deps as well + style fixes #211

Merged
merged 3 commits into from
Apr 25, 2013

Conversation

boegel
Copy link
Member

@boegel boegel commented Apr 4, 2013

Depends on easybuilders/easybuild-easyblocks#171 for ESMF support and enabling ESMF/UDUNITS in the NCL builds.


toolchain = {'name': 'goolf', 'version': '1.4.10'}

sources = ['%s-%s.tar.gz' % (name.lower(), version)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use constant here?

@JensTimmerman
Copy link
Contributor

looking fine for me (except maybe some (deprecated) non-use of templating)

@boegel
Copy link
Member Author

boegel commented Apr 25, 2013

Remarks fixed, unit tests pass, on hold until easybuilders/easybuild-easyblocks#171 is reviewed and merged.

boegel added a commit that referenced this pull request Apr 25, 2013
add NCL deps ESMF and UDUNITS, and their deps as well + style fixes
@boegel boegel merged commit 7d5d18a into easybuilders:develop Apr 25, 2013
@boegel boegel mentioned this pull request Apr 27, 2013
@boegel boegel deleted the NCL_deps branch June 22, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants