Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{lang}[intel-2016a] R 3.2.3 with libX11 1.6.3 (REVIEW) #2624

Merged
merged 8 commits into from
Mar 8, 2016

Conversation

hajgato
Copy link
Collaborator

@hajgato hajgato commented Mar 3, 2016

Needs #2621

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6763/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

('Tcl', '8.6.4'), # for tcltk
('Tk', '8.6.4', versionsuffix), # for tcltk
('cURL', '7.47.0'), # for RCurl
('libxml2', '2.9.3', '-Python-2.7.11%s' % versionsuffix), # for XML
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need libxml with Python bindings enabled?

if we can get around including Python as an (indirect) dep for R, I think we should?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel Not, but cairo have a GLib dependency, and GLib have a libxml2-Python dependency. So all the chain should have libxml2-Python dependency to avoid conflicts (or we have to delete the Python dependency of the existing GLib easyconfig.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a "dontload@build" option in case of Dependencies, so that dep is not loaded during the build. I mean, in case of GLlib Python is only a builddep, but we have to use libxml2 with Python capabilities. libxml2 with Python could be builddep, and normal libxml2 could be the dep, with "dontload@build"
This should help us to easier handle circular dependencies.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think using two different libxml2 builds as build dep/runtime dep is a good idea...

Who knows what happens during the build, it may remember where the libxml2 it was built on top of is installed.

Why do we have to use libxml2 w/ Python in GLib? And how can Python only be a build dep then?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel: I am not able to answer to that question. Most of the GLib easyconfigs have Python as builddep, and normal libxml2 as dep. The latest version (2.47.5) has a 'libxml2-python` dep.
@ocaisa put it there, do not know the reason. (maybe needed only for testing?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checking the GLib configure.log, only xmlcatalog needed. And Indeed, Python must be there to build GLib there is no other way. Anyway, I am not 100% sure that we need libxml2 as dep for GLib, but I also feel that this issue should not block this PR. (maybe I am wrong here)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checking everything in bin and lib of a build I have of GLib/2.47.5 and there doesn't seem to be any dependency on libxml, I think it will work as a build dep.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the feeling that GLib does not need libxml2 at all. The only xml stuff I found there, is xmlcatalog. xml catalogs are pointing to xml documents, but anyway, we are not keen to install documentation. Moreover, not giving the --with-xml-catalog=CATALOG option to configure it defaults to /etc/xml/catalog
So probably libxml2 is not a real dep for GLib

How shoud we proceed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could try and see if GLib works without libxml2, on a setup where libxml2 is not provided by the OS?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GLib uses xmllint at build time, which is provided by libxml2, cfr. https://mail.gnome.org/archives/gtk-list/2013-April/msg00010.html

so, libxml2 is definitely a build dep

@boegel
Copy link
Member

boegel commented Mar 3, 2016

Test report by @boegel
FAILED
Build succeeded for 2 out of 5 (5 easyconfigs in this PR)
node2634.swalot.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/f851233238f58296fae4 for a full test report.

@boegel
Copy link
Member

boegel commented Mar 3, 2016

Test report by @boegel
FAILED
Build succeeded for 2 out of 5 (5 easyconfigs in this PR)
node2044.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/e98b3723685a483a474d for a full test report.

@hajgato hajgato changed the title {lang}[intel-2016a] R 3.2.3 with libX11 1.6.3 (WIP) {lang}[intel-2016a] R 3.2.3 with libX11 1.6.3 (REVIEW) Mar 4, 2016
@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6777/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6778/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@damianam
Copy link
Member

damianam commented Mar 4, 2016

Sorry for the interruption here, but I have a question:

Are we sure that the required dependency is libX11 and not libXt? I was building R these days also, and the easyconfig in the repo couldn't get built because of a missing libXt header.

@hajgato
Copy link
Collaborator Author

hajgato commented Mar 4, 2016

@damianam if you want X11 support, you need libX11, libXt, and libXmu
You probably took easyconfig from the WIP (Work In Progress) version, check the current one.

@damianam
Copy link
Member

damianam commented Mar 4, 2016

@hajgato, no, I took it from master, but it didn't build. However, after adding libXt it did. libXt loaded libX11 though. libXmu wasn't loaded. I didn't test the build, so maybe there is a hidden problem in my setup.


libx11 = 'libX11'
libxver = '1.6.3'
versionsuffix = '-%s-%s' % (libx11, libxver)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hajgato: you could use the enhanced cairo easyconfig from #2630, instead of adding one with a versionsuffix?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel: I am on it, but because the GLib-libxm2 issue, I need a GLib with libxml2-Pyhon-libX11

@hajgato hajgato changed the title {lang}[intel-2016a] R 3.2.3 with libX11 1.6.3 (REVIEW) {lang}[intel-2016a] R 3.2.3 with libX11 1.6.3 (WIP) Mar 4, 2016
@hajgato hajgato changed the title {lang}[intel-2016a] R 3.2.3 with libX11 1.6.3 (WIP) {lang}[intel-2016a] R 3.2.3 with libX11 1.6.3 (REVIEW) Mar 4, 2016
@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6811/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6812/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hajgato
Copy link
Collaborator Author

hajgato commented Mar 4, 2016

@boegel finished, Python dependency removed

@boegel boegel added this to the v2.7.0 milestone Mar 5, 2016
@boegel
Copy link
Member

boegel commented Mar 8, 2016

@hajgato: can you also include the recently added doSNOW in the list of extensions, cfr. #2649

I'm retesting this, expect a test report soon.

@boegel
Copy link
Member

boegel commented Mar 8, 2016

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2090.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/41a85bffd68236993ce9 for a full test report.

@boegel
Copy link
Member

boegel commented Mar 8, 2016

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2668.swalot.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/85c159b23da33d7d7a37 for a full test report.

@hajgato
Copy link
Collaborator Author

hajgato commented Mar 8, 2016

@boegel doSNOW added.
It would be nice, if we could maintain extension lists for multiple easyconfigs, for example Rand R with X, Python and Python with X etc.

@boegel
Copy link
Member

boegel commented Mar 8, 2016

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2668.swalot.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/bdfc144875c4721dfef4 for a full test report.

@boegel
Copy link
Member

boegel commented Mar 8, 2016

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2090.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/3185523be1924cefdb8e for a full test report.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6923/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member

boegel commented Mar 8, 2016

Going in, thanks @hajgato!

boegel added a commit that referenced this pull request Mar 8, 2016
{lang}[intel-2016a] R 3.2.3 with libX11 1.6.3 (REVIEW)
@boegel boegel merged commit a7ac7a1 into easybuilders:develop Mar 8, 2016
@hajgato hajgato deleted the R-X branch June 8, 2017 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants