Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing libX dependencies for cairo #2630

Merged
merged 4 commits into from
Mar 4, 2016

Conversation

boegel
Copy link
Member

@boegel boegel commented Mar 4, 2016

When looking into adding support for Glade, I ran into missing dependencies for cairo~~, and some misspecified build deps in X11 libraries that should actually be runtime dependencies (as specified in the pkg-config files for these libraries).~~

The latter was changed in the latest 2016 easyconfigs for the X11 libraries done by @hajgato (cfr. #2549, #2563, #2614)

@boegel boegel added this to the v2.7.0 milestone Mar 4, 2016
@boegel
Copy link
Member Author

boegel commented Mar 4, 2016

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in this PR)
node2151.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/7b330d528ba95ff5aeae for a full test report.

@boegel
Copy link
Member Author

boegel commented Mar 4, 2016

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in this PR)
node2668.swalot.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/4164b01764d2d23be203 for a full test report.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6786/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hajgato
Copy link
Collaborator

hajgato commented Mar 4, 2016

protos are always headers and nothing else, so I suggest them to use only as builddeps, and never deps. This means that if you need to build something that requires some X11 libs, you might have to include some of the protos as a builddep as well. (not always).

@boegel boegel changed the title add missing dependencies for cairo, fix build vs runtime deps in X11 libs add missing libX dependencies for cairo Mar 4, 2016
@hajgato
Copy link
Collaborator

hajgato commented Mar 4, 2016

@boegel: mayve we have to explicitly add libX11 as dependency (despite is automatically loaded by those Xlibs). The shared object is also depends on libX11.so. But it is up to your taste, otherwise it is fine.

@boegel
Copy link
Member Author

boegel commented Mar 4, 2016

@hajgato: makes sense, will do, thanks for the suggestion

@hajgato
Copy link
Collaborator

hajgato commented Mar 4, 2016

@boegel:
shoot, you might need to add

builddependencies = [
    ('renderproto', '0.11'),
]

@boegel
Copy link
Member Author

boegel commented Mar 4, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2151.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.11
See https://gist.github.com/6218860aae17898d01c2 for a full test report.

@boegel
Copy link
Member Author

boegel commented Mar 4, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2668.swalot.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/bd2ac6ff7c66a35c7908 for a full test report.

@boegel
Copy link
Member Author

boegel commented Mar 4, 2016

@hajgato: ok, will add that too

('libXrender', '0.9.9'),
('libXext', '1.3.3'),
]
builddependencies = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

above dependencies?
extra empty line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have strict guidelines for this imho..

I think you'll find all combos w.r.t. order and empty line in between or not.

Let's change this consistently once we have an automated check for it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, then. :)

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6787/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6788/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6789/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member Author

boegel commented Mar 4, 2016

Thanks for the review @hajgato!

boegel added a commit that referenced this pull request Mar 4, 2016
add missing libX dependencies for cairo
@boegel boegel merged commit 9c0515f into easybuilders:develop Mar 4, 2016
@boegel boegel deleted the cairo_deps branch March 4, 2016 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants