Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{tools}[dummy/] wkhtmltopdf v0.12.3 #3098

Merged
merged 3 commits into from
May 24, 2016
Merged

{tools}[dummy/] wkhtmltopdf v0.12.3 #3098

merged 3 commits into from
May 24, 2016

Conversation

pescobar
Copy link
Member

(created using eb --new-pr)

@boegel boegel added this to the v2.9.0 milestone May 23, 2016
@boegel
Copy link
Member

boegel commented May 23, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2159.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/a33d204866c28db2cc370a89222d1b31 for a full test report.

@boegel
Copy link
Member

boegel commented May 23, 2016

lgtm

@pescobar
Copy link
Member Author

this one has many system deps: http://wkhtmltopdf.org/downloads.html

depends on: zlib, fontconfig, freetype, X11 libs (libX11, libXext, libXrender)

@boegel
Copy link
Member

boegel commented May 24, 2016

@pescobar should we list them in osdependencies? I wouldn't go and include them in real deps for a dummy install...

@pescobar
Copy link
Member Author

@boegel I added os deps for redhat/ubuntu

boegel
boegel reviewed May 24, 2016
View reviewed changes
easybuild/easyconfigs/w/wkhtmltopdf/wkhtmltopdf-0.12.3-Linux-x86_64.eb
source_urls = ['http://download.gna.org/wkhtmltopdf/%(version_major_minor)s/%(version)s/']
sources = ['wkhtmltox-%(version)s_linux-generic-amd64.tar.xz']

osdependencies = [('zlib', 'zlib1g'), 'fontconfig', ('freetype', 'libfreetype6'), ('libX11', 'libx11-6'), ('libXext', 'libxext6'), ('libXrender', 'libxrender1')]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pescobar line too long, let's go with one per line?

osdependencies = [
    ('zlib', 'zlib1g'),
    'fontconfig',
    ('freetype', 'libfreetype6'),
    ('libX11', 'libx11-6'),
    ('libXext', 'libxext6'),
    ('libXrender', 'libxrender1'),
]

@pescobar pescobar closed this May 24, 2016
@pescobar pescobar reopened this May 24, 2016
@boegel
Copy link
Member

boegel commented May 24, 2016

@pescobar no need to close/open on every push you do, Travis is picking up new commits correctly now?

@boegel
Copy link
Member

boegel commented May 24, 2016

lgtm

@boegel
Copy link
Member

boegel commented May 24, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2428.golett.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/709d50030a74635dfe0981f70e072523 for a full test report.

@boegel
Copy link
Member

boegel commented May 24, 2016

Going in, thanks @pescobar!

@boegel boegel merged commit 0177552 into easybuilders:develop May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pescobar @boegel