Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{chem}[intel/2016a] Amber 14 w/ AmberTools 15 (REVIEW) #3200

Merged
merged 1 commit into from
Jun 14, 2016
Merged

{chem}[intel/2016a] Amber 14 w/ AmberTools 15 (REVIEW) #3200

merged 1 commit into from
Jun 14, 2016

Conversation

boegel
Copy link
Member

@boegel boegel commented Jun 10, 2016 •
edited
Loading

heavily based on @thiell's PR #2794

requires easybuilders/easybuild-easyblocks#958

@boegel boegel added this to the v2.9.0 milestone Jun 10, 2016
@boegel
Copy link
Member Author

boegel commented Jun 11, 2016

Test report by @boegel
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
node2159.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/371e67bd37933ee6938c4d71113f8130 for a full test report.

@boegel
Copy link
Member Author

boegel commented Jun 11, 2016

Test report by @boegel
FAILED
Build succeeded for 1 out of 2 (1 easyconfigs in this PR)
node2437.golett.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/d17a62a93a340be336e8fd4a2724814b for a full test report.

@boegel
Copy link
Member Author

boegel commented Jun 13, 2016

Test report by @boegel
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
node2160.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/1114bf0d62c8ddf2a43d6b844b2ecc58 for a full test report.

@boegel boegel mentioned this pull request Jun 13, 2016
Closed
@boegel
Copy link
Member Author

boegel commented Jun 13, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2476.golett.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/13e88fa9b0d16d26669b08599c24ed99 for a full test report.

@boegel
Copy link
Member Author

boegel commented Jun 13, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2530.golett.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/685d79a0fdabef943e60cedb4de1fd7c for a full test report.

@boegel
Copy link
Member Author

boegel commented Jun 13, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2159.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/2478ec68c5a404a0e72e24384000b82c for a full test report.

@boegel boegel mentioned this pull request Jun 14, 2016
Merged
@boegel boegel changed the title {chem}[intel/2016a] Amber 14 w/ AmberTools 15 (WIP) {chem}[intel/2016a] Amber 14 w/ AmberTools 15 (REVIEW) Jun 14, 2016
boegel
boegel reviewed Jun 14, 2016
View reviewed changes
easybuild/easyconfigs/a/Amber/Amber-14-intel-2016a-AmberTools-15-patchlevel-13-13.eb
patchlevels = (13, 13)
patchruns = 1

versionsuffix = '-AmberTools-%s-patchlevel-%d-%d' % (ambertools_ver, patchlevels[0], patchlevels[1])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still sort of in doubt about this part...

I feel the patch level for both Amber and AmberTools should be reflected in the versionsuffix somehow...

@wpoely86 thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the patchlevels anywhere in the source, so why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using different patchlevels will result in a different build, since they determine how the source gets patched by the easyblock using the update_amber tool

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cfr. https://github.com/hpcugent/easybuild-easyblocks/pull/958/files#diff-afbdf92ed93ed0bc5b979921a0b9d4a6R81

@wpoely86
Copy link
Member

👍

@boegel
Copy link
Member Author

boegel commented Jun 14, 2016

Thanks for the review @wpoely86!

@boegel boegel merged commit 6eaa9fa into easybuilders:develop Jun 14, 2016
@boegel boegel deleted the Amber14AmberTools15_intel2016a branch June 14, 2016 10:34
This was referenced Jun 14, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@boegel @wpoely86