Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio} [intel/2017a] Trinity 2.5.1 #5451

Merged
merged 5 commits into from Dec 8, 2017

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Dec 1, 2017

No description provided.

description = """Trinity represents a novel method for the efficient and robust de novo reconstruction
of transcriptomes from RNA-Seq data. Trinity combines three independent software modules: Inchworm,
Chrysalis, and Butterfly, applied sequentially to process large volumes of RNA-Seq reads."""
toolchain = {'name': 'intel', 'version': '2017a'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please include an empty line above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Chrysalis, and Butterfly, applied sequentially to process large volumes of RNA-Seq reads."""
toolchain = {'name': 'intel', 'version': '2017a'}
toolchainopts = {'optarch': True}
preinstallopts = "JAVA_TOOL_OPTIONS=-Dfile.encoding=UTF8 "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved down, below the dependencies block (with an empty line above).

Maybe also include a comment why this is needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option did not work, I forgot to remove it. I had to set it in the easyblock file, see
easybuilders/easybuild-easyblocks#1302

patches = [
'chrysalis_commandline_noconsts_2012-10-05.patch',
'Trinity-2.5.1_plugins-Makefile.patch',
'Trinity-2.5.1_icpc.patch',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please avoid hardcoding 2.5.1 here, use %(version)s instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

]

builddependencies = [
('Autotools', '20150215', '', ('GCCcore', '6.3.0')),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be no need to hardcode the toolchain, just use ('Autotools', '20150215')?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

]

dependencies = [
('Java', '1.8.0_121', '', True),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use latest 1.8.0_152?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest ant-compatible version of Java is 1.8.0_144

@boegel boegel added the update label Dec 3, 2017
@easybuilders easybuilders deleted a comment from boegelbot Dec 3, 2017
@boegel boegel added this to the 3.5.0 milestone Dec 3, 2017
Chrysalis, and Butterfly, applied sequentially to process large volumes of RNA-Seq reads."""

toolchain = {'name': 'intel', 'version': '2017a'}
toolchainopts = {'optarch': True}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoors Please remove this line, optarch is already enabled by default.

]

dependencies = [
('Java', '1.8.0_144', '', True),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use latest 1.8.0_152?

You will need to include an ant easyconfig that uses it (make that latest ant version too).

@easybuilders easybuilders deleted a comment from boegelbot Dec 8, 2017
@boegel
Copy link
Member

boegel commented Dec 8, 2017

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2410.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/1f8727175de526020d6e8ba8fe7389ac for a full test report.

@boegel
Copy link
Member

boegel commented Dec 8, 2017

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2085.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/d77a4311422e7a61b8b0a72f4146b327 for a full test report.

@boegel
Copy link
Member

boegel commented Dec 8, 2017

Going in, thanks @smoors!

@boegel boegel merged commit 6b505bc into easybuilders:develop Dec 8, 2017
@smoors smoors deleted the trinity-intel2017a branch January 27, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants