New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{bio} [intel/2017a] Trinity 2.5.1 #5451
Conversation
description = """Trinity represents a novel method for the efficient and robust de novo reconstruction | ||
of transcriptomes from RNA-Seq data. Trinity combines three independent software modules: Inchworm, | ||
Chrysalis, and Butterfly, applied sequentially to process large volumes of RNA-Seq reads.""" | ||
toolchain = {'name': 'intel', 'version': '2017a'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please include an empty line above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Chrysalis, and Butterfly, applied sequentially to process large volumes of RNA-Seq reads.""" | ||
toolchain = {'name': 'intel', 'version': '2017a'} | ||
toolchainopts = {'optarch': True} | ||
preinstallopts = "JAVA_TOOL_OPTIONS=-Dfile.encoding=UTF8 " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be moved down, below the dependencies
block (with an empty line above).
Maybe also include a comment why this is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This option did not work, I forgot to remove it. I had to set it in the easyblock file, see
easybuilders/easybuild-easyblocks#1302
patches = [ | ||
'chrysalis_commandline_noconsts_2012-10-05.patch', | ||
'Trinity-2.5.1_plugins-Makefile.patch', | ||
'Trinity-2.5.1_icpc.patch', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please avoid hardcoding 2.5.1
here, use %(version)s
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
] | ||
|
||
builddependencies = [ | ||
('Autotools', '20150215', '', ('GCCcore', '6.3.0')), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there should be no need to hardcode the toolchain, just use ('Autotools', '20150215')
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
] | ||
|
||
dependencies = [ | ||
('Java', '1.8.0_121', '', True), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use latest 1.8.0_152
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest ant-compatible version of Java is 1.8.0_144
Chrysalis, and Butterfly, applied sequentially to process large volumes of RNA-Seq reads.""" | ||
|
||
toolchain = {'name': 'intel', 'version': '2017a'} | ||
toolchainopts = {'optarch': True} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smoors Please remove this line, optarch
is already enabled by default.
] | ||
|
||
dependencies = [ | ||
('Java', '1.8.0_144', '', True), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use latest 1.8.0_152
?
You will need to include an ant
easyconfig that uses it (make that latest ant
version too).
Test report by @boegel |
Test report by @boegel |
Going in, thanks @smoors! |
No description provided.